[8.11] [Synthetics] Sumary query backward compatability (#168817) (#1…

…69001)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Synthetics] Sumary query backward compatability
(#168817)](#168817)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-16T16:24:58Z","message":"[Synthetics]
Sumary query backward compatability (#168817)\n\n## Summary\n\nSummary
query backward compatibility !!\n\n\n### Testing\n\nEasiest way to test
this is to test this SNAPSHOT version against\nsynthetics service prod
locations","sha":"36cd0c6045231098bfffa7245f380a9ed0a31a75","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:uptime","release_note:skip","v8.11.0","v8.12.0"],"number":168817,"url":"https://github.com/elastic/kibana/pull/168817","mergeCommit":{"message":"[Synthetics]
Sumary query backward compatability (#168817)\n\n## Summary\n\nSummary
query backward compatibility !!\n\n\n### Testing\n\nEasiest way to test
this is to test this SNAPSHOT version against\nsynthetics service prod
locations","sha":"36cd0c6045231098bfffa7245f380a9ed0a31a75"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168817","number":168817,"mergeCommit":{"message":"[Synthetics]
Sumary query backward compatability (#168817)\n\n## Summary\n\nSummary
query backward compatibility !!\n\n\n### Testing\n\nEasiest way to test
this is to test this SNAPSHOT version against\nsynthetics service prod
locations","sha":"36cd0c6045231098bfffa7245f380a9ed0a31a75"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <[email protected]>

x-pack/plugins/synthetics/common/constants/client_defaults.ts

@@ -46,11 +46,54 @@ export const CLIENT_DEFAULTS = {
 
 export const EXCLUDE_RUN_ONCE_FILTER = { bool: { must_not: { exists: { field: 'run_once' } } } };
 export const FINAL_SUMMARY_FILTER = {
-  term: {
-    'summary.final_attempt': true,
+  bool: {
+    filter: [
+      {
+        exists: {
+          field: 'summary',
+        },
+      },
+      {
+        bool: {
+          should: [
+            {
+              bool: {
+                should: [
+                  {
+                    match: {
+                      'summary.final_attempt': true,
+                    },
+                  },
+                ],
+                minimum_should_match: 1,
+              },
+            },
+            {
+              bool: {
+                must_not: {
+                  bool: {
+                    should: [
+                      {
+                        exists: {
+                          field: 'summary.final_attempt',
+                        },
+                      },
+                    ],
+                    minimum_should_match: 1,
+                  },
+                },
+              },
+            },
+          ],
+          minimum_should_match: 1,
+        },
+      },
+    ],
   },
 };
 
+export const SUMMARY_FILTER = { exists: { field: 'summary' } };
+
 export const getLocationFilter = ({
   locationName,
   locationId,

x-pack/plugins/synthetics/public/apps/synthetics/components/error_details/components/error_duration.tsx

@@ -9,8 +9,8 @@ import { EuiDescriptionList } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 
 import moment, { Moment } from 'moment';
+import { useErrorFailedTests } from '../hooks/use_error_failed_tests';
 import { useFindMyKillerState } from '../hooks/use_find_my_killer_state';
-import { useErrorFailedTests } from '../hooks/use_last_error_state';
 
 export const ErrorDuration: React.FC = () => {
   const { failedTests } = useErrorFailedTests();

x-pack/plugins/synthetics/public/apps/synthetics/components/error_details/components/error_started_at.tsx

@@ -8,7 +8,7 @@ import React, { ReactElement } from 'react';
 import { EuiDescriptionList, EuiSkeletonText } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 
-import { useErrorFailedTests } from '../hooks/use_last_error_state';
+import { useErrorFailedTests } from '../hooks/use_error_failed_tests';
 import { useDateFormat } from '../../../../../hooks/use_date_format';
 
 export const ErrorStartedAt: React.FC = () => {

x-pack/plugins/synthetics/public/apps/synthetics/components/error_details/components/failed_tests_list.tsx

@@ -39,6 +39,8 @@ export const FailedTestsList = ({
 
   const formatter = useDateFormat();
 
+  // TODO: this is broken for ping monitors
+
   const columns = [
     {
       field: '@timestamp',

x-pack/plugins/synthetics/public/apps/synthetics/components/error_details/hooks/use_error_failed_tests.tsx

@@ -5,13 +5,13 @@
  * 2.0.
  */
 
-import { useEsSearch } from '@kbn/observability-shared-plugin/public';
 import { useParams } from 'react-router-dom';
 import { useMemo } from 'react';
+import { useReduxEsSearch } from '../../../hooks/use_redux_es_search';
 import { Ping } from '../../../../../../common/runtime_types';
 import {
   EXCLUDE_RUN_ONCE_FILTER,
-  FINAL_SUMMARY_FILTER,
+  SUMMARY_FILTER,
 } from '../../../../../../common/constants/client_defaults';
 import { SYNTHETICS_INDEX_PATTERN } from '../../../../../../common/constants';
 import { useSyntheticsRefreshContext } from '../../../contexts';
@@ -24,15 +24,15 @@ export function useErrorFailedTests() {
 
   const { dateRangeStart, dateRangeEnd } = useGetUrlParams();
 
-  const { data, loading } = useEsSearch(
+  const { data, loading } = useReduxEsSearch(
     {
       index: SYNTHETICS_INDEX_PATTERN,
       body: {
         size: 10000,
         query: {
           bool: {
             filter: [
-              FINAL_SUMMARY_FILTER,
+              SUMMARY_FILTER,
               EXCLUDE_RUN_ONCE_FILTER,
               {
                 term: {

x-pack/plugins/synthetics/public/apps/synthetics/components/monitor_details/hooks/use_monitor_errors.tsx

@@ -11,7 +11,7 @@ import { useSelectedLocation } from './use_selected_location';
 import { Ping, PingState } from '../../../../../../common/runtime_types';
 import {
   EXCLUDE_RUN_ONCE_FILTER,
-  FINAL_SUMMARY_FILTER,
+  SUMMARY_FILTER,
 } from '../../../../../../common/constants/client_defaults';
 import { SYNTHETICS_INDEX_PATTERN } from '../../../../../../common/constants';
 import { useSyntheticsRefreshContext } from '../../../contexts';
@@ -37,7 +37,7 @@ export function useMonitorErrors(monitorIdArg?: string) {
         query: {
           bool: {
             filter: [
-              FINAL_SUMMARY_FILTER,
+              SUMMARY_FILTER,
               EXCLUDE_RUN_ONCE_FILTER,
               {
                 range: {

x-pack/plugins/synthetics/server/common/pings/query_pings.ts

@@ -10,6 +10,7 @@ import {
   QueryDslFieldAndFormat,
   QueryDslQueryContainer,
 } from '@elastic/elasticsearch/lib/api/typesWithBodyKey';
+import { SUMMARY_FILTER } from '../../../common/constants/client_defaults';
 import { UptimeEsClient } from '../../lib';
 import {
   GetPingsParams,
@@ -20,43 +21,6 @@ import {
 
 const DEFAULT_PAGE_SIZE = 25;
 
-/**
- * This branch of filtering is used for monitors of type `browser`. This monitor
- * type represents an unbounded set of steps, with each `check_group` representing
- * a distinct journey. The document containing the `summary` field is indexed last, and
- * contains the data necessary for querying a journey.
- *
- * Because of this, when querying for "pings", it is important that we treat `browser` summary
- * checks as the "ping" we want. Without this filtering, we will receive >= N pings for a journey
- * of N steps, because an individual step may also contain multiple documents.
- */
-const REMOVE_NON_SUMMARY_BROWSER_CHECKS = {
-  must_not: [
-    {
-      bool: {
-        filter: [
-          {
-            term: {
-              'monitor.type': 'browser',
-            },
-          },
-          {
-            bool: {
-              must_not: [
-                {
-                  exists: {
-                    field: 'summary',
-                  },
-                },
-              ],
-            },
-          },
-        ],
-      },
-    },
-  ],
-};
-
 function isStringArray(value: unknown): value is string[] {
   if (!Array.isArray(value)) return false;
   // are all array items strings
@@ -72,14 +36,6 @@ type GetParamsWithFields<F> = GetPingsParams & {
 
 type GetParamsWithoutFields = GetPingsParams;
 
-export function queryPings(
-  params: GetPingsParams & { uptimeEsClient: UptimeEsClient }
-): Promise<PingsResponse>;
-
-export function queryPings<F>(
-  params: GetParamsWithFields<F> & { uptimeEsClient: UptimeEsClient }
-): Promise<{ total: number; pings: F[] }>;
-
 export async function queryPings<F>(
   params: (GetParamsWithFields<F> | GetParamsWithoutFields) & { uptimeEsClient: UptimeEsClient }
 ): Promise<PingsResponse | { total: number; pings: F[] }> {
@@ -105,12 +61,12 @@ export async function queryPings<F>(
     query: {
       bool: {
         filter: [
+          SUMMARY_FILTER,
           { range: { '@timestamp': { gte: from, lte: to } } },
           ...(monitorId ? [{ term: { 'monitor.id': monitorId } }] : []),
           ...(status ? [{ term: { 'monitor.status': status } }] : []),
           ...(finalAttempt ? [{ term: { 'summary.final_attempt': finalAttempt } }] : []),
         ] as QueryDslQueryContainer[],
-        ...REMOVE_NON_SUMMARY_BROWSER_CHECKS,
       },
     },
     sort: [{ '@timestamp': { order: (sort ?? 'desc') as 'asc' | 'desc' } }],