-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serverless] Add panels to side nav #167774
[Serverless] Add panels to side nav #167774
Conversation
14a787b
to
cf626e7
Compare
cf626e7
to
91e9e49
Compare
547dc82
to
814fdea
Compare
…sebelga/kibana into serverless-chrome/add-panel-to-side-nav
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
search changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security Solution code LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work 👏
I tested storybook, search and obit.
Also tried to explore sideNavStatus option for fixing some breadcrumbs, but there are some other things that need to be done first
); | ||
|
||
const onIconClick = useCallback(() => { | ||
openPanel(item); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should clicking the icon again close the panel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting... I didn't think about that. I might not re-launch a full CI for that but I'm adding it to my current branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APM changes LGTM
@elasticmachine merge upstream |
…dd-panel-to-side-nav
…sebelga/kibana into serverless-chrome/add-panel-to-side-nav
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
Great work, @sebelga !! |
This PR add supports for "panels" in the serverless side navigation.
Notes for reviewer
yarn storybook shared_ux
API
renderAs
propertyIn order to indicate that a group in the side navigation should open a panel we use the
renderAs
property and set it to'panelOpener'
.Tree definition
With UI components
Configure the content to render in the panel
There are 2 ways to configure the content that is rendered in the panel:
Generate automatically
To generate automatically the content of the panel we simply add nested groups with their children to the navigation tree.
Provide a custom component
If there is a need to render a custom component instead of the generated one we can pass a
panelContentProvider
Screenshots