Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[o11y alerting serverless] Incomplete breadcrumbs #161447

Closed
emma-raffenne opened this issue Jul 7, 2023 · 8 comments · Fixed by #169401 or #169778
Closed

[o11y alerting serverless] Incomplete breadcrumbs #161447

emma-raffenne opened this issue Jul 7, 2023 · 8 comments · Fixed by #169401 or #169778
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Project:Serverless Work as part of the Serverless project for its initial release Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Milestone

Comments

@emma-raffenne
Copy link
Contributor

Environment

  • Kibana Observability serverless 8.10 main branch yarn start --serverless=oblt
  • Elasticsearch stateful 8.9.0
  • Deployment: local MacOS 12.6.7

Describe the bug

Breadcrumbs show "Home > Alerts" despite being on rules or rule detail pages.

Steps to reproduce

  1. Start/Deploy Kibana Observability in serverless mode
  2. Go to "Alerts"
  3. Go to "Manage Rules"

Expected behaviour

Breadcrumbs to show the path corresponding to the current page

Screenshots

Screenshot_2023-07-07_at_11_35_15
@emma-raffenne emma-raffenne added bug Fixes for quality problems that affect the customer experience Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Project:Serverless Work as part of the Serverless project for its initial release labels Jul 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@emma-raffenne emma-raffenne changed the title [o11y alerting] Incomplete breadcrumbs [o11y alerting] Incomplete breadcrumbs in Serverless mode Jul 7, 2023
@emma-raffenne emma-raffenne changed the title [o11y alerting] Incomplete breadcrumbs in Serverless mode [o11y alerting serverless] Incomplete breadcrumbs Jul 7, 2023
@emma-raffenne emma-raffenne added this to the 8.11 milestone Aug 7, 2023
@cnasikas
Copy link
Member

cnasikas commented Sep 7, 2023

I also noticed that the Cases breadcrumbs do not work correctly in the O11y Serverless project. In Cases, we use serverless.setBreadcrumbs to append custom deeper context (the title of the case for example when viewing a case). As the main parts of the breadcrumbs's path are automatically calculated from the side nav + current URL I suspect that the NavigationTree is not set correctly. In the Security project, this does not occur. I tried to add

{
   "link":"observability-overview:cases",
   "children":[
      {
         "link":"observability-overview:cases_configure"
      },
      {
         "link":"observability-overview:cases_create"
      }
   ]
}

in the navigationTree defined here x-pack/plugins/serverless_observability/public/components/side_navigation/index.tsx without success. The pages that are affected are the create case and the configure case.

@simianhacker
Copy link
Member

@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@semd
Copy link
Contributor

semd commented Sep 28, 2023

The issue is caused by the navLinkStatus: hidden of the deepLink configuration. This is usually used when we want to hide links from the side navigation menu, but it is also used for unauthorized (license, capabilities...) links sometimes.

The shared-ux navigation component, to prevent showing broken links, filters all hidden links out of the chrome navigationTree registered, so the breadcrumbs for these pages are not configured either.

It would be great to have a clearer specification of what a hidden link means, because we are using it for two different purposes, if solutions do not set the navLinkStatus: hidden in these (authorized) links there's no other way to prevent them from showing in the side navigation menu.

@Dosant
Copy link
Contributor

Dosant commented Oct 12, 2023

This is still relevant. I think the best approach would be to add the alerts sub-pages to the navigation tree for the breadcrumbs (but keep them hidden in the side nav). But this isn't possible now, it should be after #166883 is done.
We will still need to call serveless.setBreadcrumbs manually to append deeper context which is dynamic (like rule name)

@cnasikas
Copy link
Member

I tested and for Cases this is still relevant.

@semd
Copy link
Contributor

semd commented Oct 17, 2023

#167774 Will introduce a way to hide links from the side nav (sideNavStatus: 'hidden') without removing them from the serverless navigationTree, so the breadcrumbs will be generated automatically.

However, solution will have to set navLinkStatus: "visible' to those links in the plugin deepLinks registry, having navLinkStatus: "hidden' (or undefined) there will still filter the link out from the final serverless navigationTree.

Dosant added a commit that referenced this issue Oct 23, 2023
## Summary

partially fixes #161447
 
Fixed "Create Case" and "Manage Cases" breadcrumbs
@Dosant Dosant reopened this Oct 26, 2023
Dosant added a commit that referenced this issue Oct 27, 2023
## Summary

Close #161447

This fixes deeper context breadcrumbs in serverless observability
project for alerts and slos apps.
This builds on top of #169513
where we added merging of navigational project breadcrumbs with deeper
context breadcrumbs set by `chrome.setBreadcrumbs`. The merging is based
on deepLinkId, so we're adding it to base breadcrumbs. The deepLinkId is
type checked.

![Screenshot 2023-10-25 at 12 28
07](https://github.com/elastic/kibana/assets/7784120/947f59b3-b338-4bd1-96b9-7414bf396fae)
![Screenshot 2023-10-25 at 12 28
16](https://github.com/elastic/kibana/assets/7784120/5e73e902-3397-4b3e-9202-5c1e2c49358f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Project:Serverless Work as part of the Serverless project for its initial release Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
8 participants