Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Unskip shared links functional test #167679

Merged
merged 9 commits into from
Oct 6, 2023
Merged

[Discover] Unskip shared links functional test #167679

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5dfa036
unskip test
kertal Sep 29, 2023
211c6ca
Merge branch 'main' into functional-testing
kertal Oct 2, 2023
e84555e
Merge branch 'main' into functional-testing
kibanamachine Oct 5, 2023
0fa31ac
Merge remote-tracking branch 'upstream/main' into functional-testing
kertal Oct 5, 2023
0bff581
unskip test
kertal Oct 5, 2023
75c6a7e
Merge branch 'functional-testing' of github.com:kertal/kibana into fu…
kertal Oct 5, 2023
39c25d7
Update _shared_links.ts
kertal Oct 6, 2023
24dfe69
Cleanup toasts
kertal Oct 6, 2023
6ad7886
Merge branch 'functional-testing' of github.com:kertal/kibana into fu…
kertal Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/functional/apps/discover/group1/_shared_links.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const toasts = getService('toasts');
const deployment = getService('deployment');

// Failing: See https://github.com/elastic/kibana/issues/167405
describe.skip('shared links', function describeIndexTests() {
describe('shared links', function describeIndexTests() {
let baseUrl: string;

async function setup({ storeStateInSessionStorage }: { storeStateInSessionStorage: boolean }) {
Expand Down Expand Up @@ -174,6 +173,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const resolvedTime = await PageObjects.timePicker.getTimeConfig();
expect(resolvedTime.start).to.equal(actualTime.start);
expect(resolvedTime.end).to.equal(actualTime.end);
await toasts.dismissAllToasts();
return true;
});
});
Expand Down