[Discover] Unskip shared links functional test

[kertal]

Summary

improving & unskipping functional test for sharing links

Buildkite flaky test runner (100x)
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3387

Note that it didn't fail in CI when I tested, but locally, I could reproduce it

Resolves #167405

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

[kertal]

@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[jughosta]

Is it correct that there are 2 toasts? Maybe that was the reason for the flakiness.

[kertal]

@jughosta you're right! Wonder why the flaky test runner didn't catch it, but I could reproduce locally, working on a fix

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 6ad7886

Metrics [docs]

✅ unchanged

History

• 💚 Build #165807 succeeded 39c25d7
• 💚 Build #165690 succeeded 75c6a7e
• 💔 Build #164100 failed 5dfa036

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

[kertal]

@jughosta changes applied, flaky test runner is happy

[jughosta]

Nice!

But is it fine from a user perspective to get 2 toasts or is it just from 2 different test checks?

[kertal]

There are 2 different toasts triggered by 2 different parts of our code. And 1 in this case seems to be double. It's an area for improvement I would say. But generally, the feature storing our URL state just in the browser session, newer left testing state according to advanced settings: