Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security solution] Rename Generative AI connector to OpenAI #167677

Merged
merged 15 commits into from
Sep 29, 2023

Conversation

stephmilovic
Copy link
Contributor

Redo this PR because this PR merged shortly before broke it and I had to fix an import

@stephmilovic stephmilovic added release_note:fix Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.11.0 labels Sep 29, 2023
@stephmilovic stephmilovic requested a review from a team as a code owner September 29, 2023 16:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@stephmilovic stephmilovic requested review from a team as code owners September 29, 2023 16:34
@stephmilovic stephmilovic enabled auto-merge (squash) September 29, 2023 16:44
@jbudz
Copy link
Member

jbudz commented Sep 29, 2023

This was already passing CI in #167519. One commit was added to fix a merge timing conflict with an import 674a095.

I've verified this is fixed, merging now.

@jbudz jbudz disabled auto-merge September 29, 2023 16:54
@jbudz jbudz merged commit b888ecb into elastic:main Sep 29, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 29, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #2 / Serverless Common UI - Management Indices "before all" hook for "renders the indices tab"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityAIAssistant 199.9KB 199.9KB -20.0B
securitySolution 12.8MB 12.8MB +20.0B
stackConnectors 485.5KB 485.5KB -33.0B
total -33.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
actions 15.9KB 15.9KB +26.0B
stackConnectors 37.8KB 37.8KB -5.0B
total +21.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants