-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security solution] Rename Generative AI connector to OpenAI #167519
Conversation
Documentation preview: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @mdbirnstiehl are there any other docs that need to be updated?
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Response Ops changes LGTM
x-pack/plugins/stack_connectors/public/connector_types/open_ai/types.ts
Outdated
Show resolved
Hide resolved
@lcawl Could you please help me figure out how to fix this error:
|
I've created a temporary "redirect" page in this PR and then we can fix the broken links in the Observability and Security docs via elastic/observability-docs#3251 and elastic/security-docs#4000 |
x-pack/plugins/stack_connectors/public/connector_types/d3security/d3security.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🤖
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
This was reverted with 7dd352a. See https://buildkite.com/elastic/kibana-on-merge/builds/36052,
|
Summary
Follow up from #166662
Resolves items 1 and 2 of issue #166960
.gen-ai
id so no migration needed)I tried to leave o11y code alone besides file path changes and a few translations related directly to the connector name. @dgieselaar could you please take a look and let me know if I should do more or less?