Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security solution] Rename Generative AI connector to OpenAI #167519

Merged
merged 11 commits into from
Sep 29, 2023

Conversation

stephmilovic
Copy link
Contributor

Summary

Follow up from #166662

Resolves items 1 and 2 of issue #166960

  1. Renames Generative AI connector to OpenAI (keeps .gen-ai id so no migration needed)
  2. Renames GeneralConnectorFeatureId to GenerativeAIConnectorFeatureId

I tried to leave o11y code alone besides file path changes and a few translations related directly to the connector name. @dgieselaar could you please take a look and let me know if I should do more or less?

@stephmilovic stephmilovic added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.11.0 labels Sep 28, 2023
@github-actions
Copy link
Contributor

Documentation preview:

Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @mdbirnstiehl are there any other docs that need to be updated?

@stephmilovic stephmilovic marked this pull request as ready for review September 28, 2023 16:40
@stephmilovic stephmilovic requested review from a team as code owners September 28, 2023 16:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Response Ops changes LGTM

@stephmilovic
Copy link
Contributor Author

@lcawl Could you please help me figure out how to fix this error:

11:24:39 INFO:build_docs:Bad cross-document links:
11:24:39 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/observability/master/obs-ai-assistant.html contains broken links to:
11:24:39 INFO:build_docs:   - en/kibana/master/gen-ai-action-type.html
11:24:39 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/security/master/release-notes-header-8.8.0.html contains broken links to:
11:24:39 INFO:build_docs:   - en/kibana/master/gen-ai-action-type.html
11:24:39 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/security/master/security-assistant.html contains broken links to:
11:24:39 INFO:build_docs:   - en/kibana/master/gen-ai-action-type.html
11:25:08 runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<

@lcawl
Copy link
Contributor

lcawl commented Sep 29, 2023

@lcawl Could you please help me figure out how to fix this error ...

I've created a temporary "redirect" page in this PR and then we can fix the broken links in the Observability and Security docs via elastic/observability-docs#3251 and elastic/security-docs#4000

Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤖

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #6 / Journey[many_fields_lens_editor] Open existing Lens visualization

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityAIAssistant 199.9KB 199.9KB -20.0B
securitySolution 12.8MB 12.8MB +20.0B
stackConnectors 485.5KB 485.5KB -33.0B
total -33.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
actions 15.9KB 15.9KB +26.0B
stackConnectors 37.8KB 37.8KB -5.0B
total +21.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic stephmilovic merged commit a81b620 into elastic:main Sep 29, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 29, 2023
jbudz added a commit that referenced this pull request Sep 29, 2023
@jbudz
Copy link
Member

jbudz commented Sep 29, 2023

This was reverted with 7dd352a. See https://buildkite.com/elastic/kibana-on-merge/builds/36052,

Error: Cannot find module '@kbn/stack-connectors-plugin/common/gen_ai/constants' from 'x-pack/plugins/elastic_assistant/server/routes/evaluate/utils.ts'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes reverted Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants