Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ftr] unskip serverless functional tests #167497

Merged
merged 4 commits into from
Sep 29, 2023
Merged

[ftr] unskip serverless functional tests #167497

merged 4 commits into from
Sep 29, 2023

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Sep 28, 2023 •
edited
Loading

I hope the change made in #166936 allow us to unskip these tests

closes #165763
closes #165386
closes #165414
closes #166448
closes #165943
closes #166461
closes #166551

Flaky-test-runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3242

Quick stability check of re-enabled tests:

  • x-pack/test_serverless/functional/test_suites/common/examples/search_examples/partial_results_example.ts 100/100
  • x-pack/test_serverless/functional/test_suites/common/examples/unified_field_list_examples/existing_fields.ts 100/100 failures
  • x-pack/test_serverless/functional/test_suites/common/home_page.ts 100/100
  • x-pack/test_serverless/functional/test_suites/common/index_management/create_enrich_policy.ts 99/100
  • x-pack/test_serverless/functional/test_suites/observability/cases/configure.ts 49/50
  • x-pack/test_serverless/functional/test_suites/observability/observability_log_explorer/app.ts 49/50
  • x-pack/test_serverless/functional/test_suites/observability/observability_log_explorer/filter_controls.ts 49/50
  • x-pack/test_serverless/functional/test_suites/security/ftr/cases/configure.ts 49/50

@dmlemeshko dmlemeshko changed the title unskip functional tests [ftr] unskip serverless functional tests Sep 28, 2023
@dmlemeshko dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.11.0 labels Sep 28, 2023
@dmlemeshko dmlemeshko marked this pull request as ready for review September 28, 2023 13:31
@dmlemeshko dmlemeshko requested review from a team as code owners September 28, 2023 13:31
jughosta
jughosta approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Discovery changes LGTM 👍
Thanks!

tonyghiani
tonyghiani approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dmlemeshko, I was already working on getting those tests in good shape after the latest changes you merged for the login, I already have an open PR I'm working on with the same changes + other timing updates.

There shouldn't be any conflict if you merge these changes and then I update my branch 👌

@dmlemeshko dmlemeshko enabled auto-merge (squash) September 28, 2023 14:44
alisonelizabeth
alisonelizabeth approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Deployment Management changes LGTM.

@dmlemeshko dmlemeshko force-pushed the ftr/unskip-serverless-tests branch from 5ff60e8 to 2e6f4ee Compare September 29, 2023 08:18
pheyos
pheyos approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmlemeshko dmlemeshko force-pushed the ftr/unskip-serverless-tests branch from 2e6f4ee to 1439e61 Compare September 29, 2023 11:29
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #27 / core plugins rendering service exposes plugin config settings to authenticated users

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dmlemeshko dmlemeshko merged commit 97c7d7d into elastic:main Sep 29, 2023
@Dosant
Copy link
Contributor

Dosant commented Oct 2, 2023

Thank you!

@dmlemeshko dmlemeshko deleted the ftr/unskip-serverless-tests branch November 21, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyghiani tonyghiani tonyghiani approved these changes

@ymao1 ymao1 ymao1 approved these changes

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

@pheyos pheyos pheyos approved these changes

@jughosta jughosta jughosta approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test: Serverless Observability Functional Tests.x-pack/test_serverless/functional/test_suites/observability/cases/configure·ts - serverless observability UI Configure Case "before all" hook in "Configure Case" Failing test: Serverless Observability Functional Tests.x-pack/test_serverless/functional/test_suites/observability/observability_log_explorer/app·ts - serverless observability UI Observability Log Explorer Application is shown in the global search Failing test: Serverless Observability Examples Functional Tests.x-pack/test_serverless/functional/test_suites/common/examples/search_examples/partial_results_example·ts - serverless examples UI search examples Partial results example "before all" hook for "should update a progress bar" Failing test: Serverless Security Functional Tests.x-pack/test_serverless/functional/test_suites/common/home_page·ts - serverless common UI home page has project header Failing test: Serverless Observability Functional Tests.x-pack/test_serverless/functional/test_suites/common/home_page·ts - serverless common UI home page has project header
Failing test: Serverless Observability Functional Tests.x-pack/test_serverless/functional/test_suites/observability/observability_log_explorer/filter_controls·ts - serverless observability UI Observability Log Explorer Filter controls customization "before all" hook: initialize tests for "renders a filter controls section as part of the unified search bar" Failing test: Serverless Security Functional Tests.x-pack/test_serverless/functional/test_suites/security/ftr/cases/configure·ts - serverless security UI Configure Case "before all" hook in "Configure Case"
8 participants
@dmlemeshko @kibana-ci @Dosant @jughosta @pheyos @alisonelizabeth @ymao1 @tonyghiani