-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ftr] pass password for UI login + improve login/logout steps with proper wait logic #166936
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for having a go at this @dmlemeshko! It has been puzzling us why these were failing so randomly. I noticed in your flaky test runner run that some of the tests for test_suites/common/index_management
are still failing with either:
[data-test-subj="userMenuButton"] is not displayed
Waiting for element to be located By(css selector, [data-test-subj="kibanaChrome"])
Are these errors also something that can be caused by the problem you defined in the PR summary?
Hey @sabarasaba The problem you described is unfortunately still not fixed and I will revert my last changes related to After login many tests load a direct url to the Kibana app and sometimes these requests are resulting in a 401 response, and instead of Kibana app user ends up stuck at https://localhost:5620/api/security/saml/callback. For some reason
You can see that You can follow elastic/kibana-team/issues/629 for more details |
This reverts commit 9b8651f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
💔 Build FailedFailed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @dmlemeshko |
I hope the change made in #166936 allow us to unskip these tests closes #165763 closes #165386 closes #165414 closes #166448 closes #165943 closes #166461 closes #166551 Flaky-test-runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3242 Quick stability check of re-enabled tests: - x-pack/test_serverless/functional/test_suites/common/examples/search_examples/partial_results_example.ts 100/100 - x-pack/test_serverless/functional/test_suites/common/examples/unified_field_list_examples/existing_fields.ts 100/100 failures - x-pack/test_serverless/functional/test_suites/common/home_page.ts 100/100 - x-pack/test_serverless/functional/test_suites/common/index_management/create_enrich_policy.ts 99/100 - x-pack/test_serverless/functional/test_suites/observability/cases/configure.ts 49/50 - x-pack/test_serverless/functional/test_suites/observability/observability_log_explorer/app.ts 49/50 - x-pack/test_serverless/functional/test_suites/observability/observability_log_explorer/filter_controls.ts 49/50 - x-pack/test_serverless/functional/test_suites/security/ftr/cases/configure.ts 49/50
Summary
Hopefully
closes #167104
closes #167130
closes #167100
closes #167013
closes #166964
Fixing a few issues with login/logout:
My theory is that we are loading
/login
route too soon while log out was not completed yet.When we navigate to
https://localhost:5620/logout
there are multiple url re-directions with final page being Cloud login form. This PR makes sure we wait for this form to be displayed + 2500 ms extra to avoid "immediate" /login navigationFailed login on MKI:
Updating login via UI for serverless to pass password valid for deployment: currently FTR uses
changeme
for both Kibana CI & MKI.ES activate user profile call returning 500
We saw some login failures that are preceded with the following logs:
User activation happens during
POST internal/security/login
call to Kibana server.The only improvement that we can do from FTR perspective is to call this end-point via API to makes sure user is activated and only after proceed with UI login.While working on issue #4 and talking to @jeramysoucy I believe retrying login via UI will work here as well. We are checking if we are still on login page (similar to incorrect password login), waiting 2500 ms and pressing login button again.
Temporary solution is to retry login from scratch (navigation to Kibana login page & re-login )
Flaky-test-runner for functional obtl tests 50x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3215
This PR is not fixing random 401 response when user navigates to some apps with direct url