Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] AIOps: Move log pattern analysis fetch code to common to be available via server #167465

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Sep 28, 2023

Summary

Follow up to #167237.
Part of #167467.

We plan to reuse some of the queries log pattern analysis does to use via log rate analysis too. Log pattern analysis mostly does queries from the client side, log rate analysis has its own API endpoint and does ES queries via Kibana server. In preparation for the use via log rate analysis, this moves the code we need to have available server side for log rate analysis to the common area of the plugin so it can be used both on server/client.

Checklist

@walterra walterra added :ml Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis v8.11.0 labels Sep 28, 2023
@walterra walterra self-assigned this Sep 28, 2023
@walterra walterra requested a review from a team as a code owner September 28, 2023 07:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra walterra changed the title [ML] AIOps: Move log pattern analysis fetch code to common to available for server [ML] AIOps: Move log pattern analysis fetch code to common to be available via server Sep 28, 2023
@walterra walterra added the release_note:skip Skip the PR/issue when compiling release notes label Sep 28, 2023
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
aiops 476 480 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 594.0KB 594.0KB +37.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra merged commit 0d97cc7 into elastic:main Sep 28, 2023
9 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 28, 2023
@walterra walterra deleted the ml-aiops-move-log-pattern-analysis-fetch-code-to-common branch September 28, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:skip Skip the PR/issue when compiling release notes v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants