Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Move chi2test to package #167237

Merged
merged 12 commits into from
Sep 27, 2023
Merged

[ML] Move chi2test to package #167237

merged 12 commits into from
Sep 27, 2023

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Sep 26, 2023 •
edited
Loading

Summary

The chi2test utils so fare were only used within data comparison view. We plan to use it with other plugins, so moving it so a separate package in this PR. SIGNIFICANCE_LEVELS was updated to include some more digits.

Checklist

@walterra walterra added :ml release_note:skip Skip the PR/issue when compiling release notes v8.11.0 labels Sep 26, 2023
@walterra walterra requested a review from a team as a code owner September 26, 2023 11:46
@walterra walterra self-assigned this Sep 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #34 / EPM Endpoints EPM - list list api tests lists all limited packages from the registry

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dataVisualizer 574 578 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 613.3KB 613.3KB +13.0B
Unknown metric groups

API count

id before after diff
@kbn/ml-chi2test - 12 +12

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

peteharverson
peteharverson approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I gave the data comparison a test and all looks good.

@qn895
Copy link
Member

qn895 commented Sep 27, 2023

LGTM 🎉

@walterra walterra merged commit 1b9993e into elastic:main Sep 27, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 27, 2023
@walterra walterra deleted the ml-chi2test-package branch September 27, 2023 16:43
This was referenced Sep 28, 2023
Merged
Closed
walterra added a commit that referenced this pull request Sep 28, 2023
@walterra
[ML] AIOps: Move log pattern analysis fetch code to common to be av…
0d97cc7 
…ailable via `server` (#167465)

Follow up to #167237.
Part of #167467.

We plan to reuse some of the queries log pattern analysis does to use
via log rate analysis too. Log pattern analysis mostly does queries from
the client side, late rate analysis has its own API endpoint and does ES
queries via Kibana server. In preparation for the use via log rate
analysis, this moves the code we need to have available server side for
log rate analysis to the `common` area of the plugin so it can be used
both on server/client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qn895 qn895 qn895 approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@walterra walterra

Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@walterra @elasticmachine @kibana-ci @qn895 @peteharverson @kibanamachine