Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs+] Remove configurable redirects to Discover #167151

Merged
merged 10 commits into from
Sep 27, 2023
Merged

[Logs+] Remove configurable redirects to Discover #167151

merged 10 commits into from
Sep 27, 2023

Conversation

Kerry350
Copy link
Contributor

@Kerry350 Kerry350 commented Sep 25, 2023 •
edited
Loading

Summary

Closes #165227.

Removes configurable app targets. Only the standard logs app is registered (Note: Infra is disabled in serverless observability / security projects currently).

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@Kerry350
Copy link
Contributor Author

@elasticmachine merge upstream

@Kerry350 Kerry350 self-assigned this Sep 25, 2023
@Kerry350 Kerry350 added Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes labels Sep 25, 2023
@Kerry350 Kerry350 marked this pull request as ready for review September 25, 2023 19:29
@Kerry350 Kerry350 requested review from a team as code owners September 25, 2023 19:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@mohamedhamed-ahmed
Copy link
Contributor

I guess some references in APM needs to be removed as well

@Kerry350 Kerry350 requested a review from a team as a code owner September 26, 2023 12:23
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Sep 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@Kerry350
Copy link
Contributor Author

@mohamedhamed-ahmed Thanks for the pointer. I've removed the superfluous APM type reference.

mohamedhamed-ahmed
mohamedhamed-ahmed approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Kerry

@Kerry350
Copy link
Contributor Author

@elasticmachine merge upstream

jeramysoucy
jeramysoucy approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@jeramysoucy jeramysoucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in test/plugin_functional/test_suites/core_plugins/rendering.ts LGTM

@Kerry350
Copy link
Contributor Author

@elasticmachine merge upstream

yngrdyn
yngrdyn approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes LGTM

mgiota
mgiota approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@mgiota mgiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kerry350 LGTM!

@Kerry350
Copy link
Contributor Author

@elasticmachine merge upstream

@Kerry350
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 1463 1460 -3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
infra 39 38 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.0MB 2.0MB -730.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 106.5KB 105.3KB -1.3KB
Unknown metric groups

API count

id before after diff
infra 42 41 -1

async chunk count

id before after diff
infra 27 26 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kerry350

@Kerry350 Kerry350 merged commit b2271a9 into elastic:main Sep 27, 2023
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeramysoucy jeramysoucy jeramysoucy approved these changes

@mohamedhamed-ahmed mohamedhamed-ahmed mohamedhamed-ahmed approved these changes

@jloleysens jloleysens jloleysens approved these changes

@mgiota mgiota mgiota approved these changes

@yngrdyn yngrdyn yngrdyn approved these changes

Assignees

@Kerry350 Kerry350

Labels
backport:skip This commit does not require backporting Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Logs UI] Remove configurable redirects to Discover
10 participants
@Kerry350 @apmmachine @elasticmachine @mohamedhamed-ahmed @kibana-ci @yngrdyn @mgiota @jloleysens @jeramysoucy @kibanamachine