Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Remove configurable redirects to Discover #165227

Closed
weltenwort opened this issue Aug 30, 2023 · 3 comments · Fixed by #167151
Closed

[Logs UI] Remove configurable redirects to Discover #165227

weltenwort opened this issue Aug 30, 2023 · 3 comments · Fixed by #167151
Assignees
@Kerry350
Labels
Feature:LogsExplorer Logs Explorer feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.11.0

Comments

@weltenwort
Copy link
Member

📓 Summary

With the recent change of plans regarding the log explorer app in ESS and serverless we don't need the configurable redirects anymore.

✔️ Acceptance criteria

  • The configuration setting xpack.infra.logs.app_target is removed.
  • The top-level redirects registered in the infra app based on that setting are removed.
@weltenwort weltenwort added Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Aug 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@mohamedhamed-ahmed
Copy link
Contributor

mohamedhamed-ahmed commented Sep 11, 2023 •
edited
Loading

That also means we no longer need the Discover node & logs locators created previously as well right ?

@weltenwort
Copy link
Member Author

yes, I don't see where we'd need them

@mohamedhamed-ahmed mohamedhamed-ahmed self-assigned this Sep 12, 2023
@mohamedhamed-ahmed mohamedhamed-ahmed removed their assignment Sep 20, 2023
@Kerry350 Kerry350 self-assigned this Sep 21, 2023
@Kerry350 Kerry350 mentioned this issue Sep 25, 2023
Merged
Kerry350 added a commit that referenced this issue Sep 27, 2023
@Kerry350 @kibanamachine
[Logs+] Remove configurable redirects to Discover (#167151)
b2271a9 
## Summary

Closes #165227.

Removes configurable app targets. Only the standard logs app is
registered (Note: [Infra is disabled in
serverless](#165289) observability
/ security projects currently).

---------

Co-authored-by: Kibana Machine <[email protected]>
@gbamparop gbamparop added Feature:LogsExplorer Logs Explorer feature and removed Feature:Logs UI Logs UI feature labels Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kerry350 Kerry350

Labels
Feature:LogsExplorer Logs Explorer feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Logs+] Remove configurable redirects to Discover Kerry350/kibana
5 participants
@Kerry350 @weltenwort @gbamparop @mohamedhamed-ahmed @elasticmachine