Upgrade EUI to v88.5.0 #166868

cee-chen · 2023-09-20T17:31:41Z

v88.3.0⏩v88.5.0

closes #151514

`88.5.0`

Updated EuiCallOut with a new onDismiss prop (#7156)
Added a new renderCustomToolbar prop to EuiDataGrid, which allows custom rendering of the toolbar. (#7190)
Added a new allowResetButton prop to toolbarVisibility.showDisplaySelector of EuiDataGrid, which allows hiding the "Reset to default" button from the display settings popover. (#7190)
Added a new additionalDisplaySettings prop to toolbarVisibility.showDisplaySelector of EuiDataGrid, which allows rendering extra settings inside the display settings popover. (#7190)
Updated EuiDataGrid's toolbar display settings button icon (#7190)
Updated EuiTextTruncate with significantly improved iteration performance. Removed measurementRenderAPI prop, as EuiTextTruncation now only uses more performant canvas render API (#7210)
Updated EuiPopover with a new configurable repositionToCrossAxis prop (#7211)
Updated EuiDatePicker to support compressed input styling (#7218)
Added gradient and palette icon glyphs. (#7220)

Bug fixes

Fixed EuiPopover's missing animations on popover close (#7211)
Fixed EuiInputPopover anchoring to the wrong side and missing shadows on smaller screens (#7211)
Fixed EuiSuperDatePicker icon spacing on the quick select button (#7217)
Fixed a missing type in EuiMarkdownEditor's default processing plugins (#7221)

`88.4.1`

Bug fixes

Fixed missing classNames on EuiTextTruncate (#7212)
Fixed titles on EuiComboBox dropdown options to always be present (#7212)
Fixed EuiComboBox truncation issues when search is an empty space (#7212)

`88.4.0`

Updated EuiComboBox to allow configuring text truncation behavior via truncationProps. These props can be set on the entire combobox as well as on on individual dropdown options. (#7028)
Updated EuiInMemoryTable with a new searchFormat prop (defaults to eql). When setting this prop to text, the built-in search bar will ignore EQL syntax and allow searching for plain strings with special characters and symbols. (#7175)

Bug fixes

EuiComboBox now always shows the highlighted search text, even on truncated text (#7028)
Fixed missing i18n in EuiSearchBar's default placeholder and aria-label text (#7175)
Fixed the inline compressed styles of EuiDescriptionListTitle to use a taller line-height for readability (#7185)
Fixed EuiComboBox to correctly truncate selected items when displayed as pills and plain text (#7193)

Accessibility

Added aria-current attribute to EuiTablePagination (#7186)

CSS-in-JS conversions

Converted EuiDroppable and EuiDraggable to Emotion; Removed $euiDragAndDropSpacing Sass variables (#7187)

elasticmachine · 2023-09-21T20:29:34Z

Pinging @elastic/eui-team (EUI)

cee-chen · 2023-09-21T20:30:48Z

👋 Marking as ready for review as Jest and FTR tests are passing, and I'm fairly confident the Cypress failures above aren't related to EUI changes (as always, let me know if that assumption is incorrect!)

Most changes in this upgrade are related to EuiComboBox and EuiDraggable/EuiDroppable (although there shouldn't be any breaking changes around them). Please feel free to QA your usages of these components and alert us if you find any regressions!

mashhurs

LGTM from Logstash!

….4.x

patrykkopycinski · 2023-09-27T07:07:31Z

@watson can we force merge this as well?

kibana-ci · 2023-09-27T17:06:36Z

💔 Build Failed

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #26 / core plugins rendering service exposes plugin config settings to authenticated users
[job] [logs] FTR Configs #21 / visualize app visual builder metric Top Hit aggregation should show correct data for string type field

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fileUpload`	957.5KB	957.5KB	-1.0B
`maps`	2.8MB	2.8MB	-1.0B
total			-2.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	367.7KB	368.3KB	+625.0B
`kbnUiSharedDeps-css`	278.7KB	275.4KB	-3.3KB
`kbnUiSharedDeps-npmDll`	6.2MB	6.3MB	+4.5KB
total			+1.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jeramysoucy

AppEx Security changes LGTM!

jbudz · 2023-09-27T18:04:29Z

osquery type fixes will be addressed at #167428.

## Summary Recent [EUI bump](#166868) from v88.3.0 to v88.5.0 increased the memory usage significantly. Due to which Cypress Tests started failing due to browser crashing with memory limits. EUI team has been informed about this. As reverting EUI is not a simple change, disabling the Cypress Log panel solves the problem for now. Details can be found [here](cypress-io/cypress#27415 (comment)) This brings change to how we run the Cypress Test in Head Mode ## Before ![image](https://github.com/elastic/kibana/assets/7416358/12a92c64-2e31-4423-8e8a-94a311757bd7) ## After ![image (1)](https://github.com/elastic/kibana/assets/7416358/d3a522c9-66e8-497c-b046-32a6c866b600)

michaelolo24 · 2023-10-25T14:10:49Z

...test/security_solution_cypress/cypress/e2e/investigations/alerts/changing_alert_status.cy.ts

@@ -63,7 +63,7 @@ describe('Changing alert status', { tags: ['@ess', '@brokenInServerless'] }, ()
      selectCountTable();
    });

-    it('Open one alert when more than one closed alerts are selected', () => {
+    it.skip('Open one alert when more than one closed alerts are selected', () => {


@patrykkopycinski - why were these tests skipped?

cee-chen force-pushed the eui-v88.4.x branch 10 times, most recently from f22a7ab to 4d1458e Compare September 21, 2023 18:25

cee-chen changed the title ~~Upgrade EUI to v88.4.0~~ Upgrade EUI to v88.4.1 Sep 21, 2023

cee-chen marked this pull request as ready for review September 21, 2023 20:29

cee-chen requested review from a team as code owners September 21, 2023 20:29

cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.11.0 labels Sep 21, 2023

jbudz approved these changes Sep 21, 2023

View reviewed changes

dej611 mentioned this pull request Sep 22, 2023

[Unified Search] Field autocomplete only matches from the beginning of the field name #158876

Open

1Copenut mentioned this pull request Sep 22, 2023

(Accessibility) Rows per page flyout on data grid should announce the selected option to screen readers #151514

Closed

mashhurs approved these changes Sep 22, 2023

View reviewed changes

patrykkopycinski requested review from maximpn and banderror as code owners September 26, 2023 18:22

patrykkopycinski removed the ci:all-cypress-suites label Sep 26, 2023

skip flaky tests

005126c

patrykkopycinski requested a review from a team as a code owner September 26, 2023 19:45

Merge branch 'main' into eui-v88.4.x

20fe0b1

patrykkopycinski approved these changes Sep 26, 2023

View reviewed changes

fix

c5265ff

patrykkopycinski requested a review from a team as a code owner September 26, 2023 20:39

patrykkopycinski requested a review from tomsonpl September 26, 2023 20:39

patrykkopycinski and others added 5 commits September 26, 2023 23:21

fix

b41fb0d

Merge branch 'main' into eui-v88.4.x

109fe71

fix

9f1bf08

Merge branch 'eui-v88.4.x' of github.com:cee-chen/kibana into eui-v88…

b834f1b

….4.x

Merge branch 'main' into eui-v88.4.x

60e406f

janmonschke approved these changes Sep 27, 2023

View reviewed changes

patrykkopycinski and others added 4 commits September 27, 2023 08:29

Merge branch 'main' into eui-v88.4.x

3c75ab4

Update tsconfig.json

59efe98

Merge branch 'main' into eui-v88.4.x

e1d8017

Merge branch 'main' into eui-v88.4.x

de64c81

jeramysoucy approved these changes Sep 27, 2023

View reviewed changes

jbudz merged commit 581b30b into elastic:main Sep 27, 2023

kibanamachine added the backport:skip This commit does not require backporting label Sep 27, 2023

cee-chen deleted the eui-v88.4.x branch September 28, 2023 17:51

achyutjhunjhunwala mentioned this pull request Sep 29, 2023

[APM] Fix cypress memory issue due to log panel #167623

Merged

michaelolo24 reviewed Oct 25, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade EUI to v88.5.0 #166868

Upgrade EUI to v88.5.0 #166868

cee-chen commented Sep 20, 2023 •

edited

Loading

elasticmachine commented Sep 21, 2023

cee-chen commented Sep 21, 2023

mashhurs left a comment

patrykkopycinski commented Sep 27, 2023

kibana-ci commented Sep 27, 2023 •

edited

Loading

jeramysoucy left a comment

jbudz commented Sep 27, 2023

michaelolo24 Oct 25, 2023 •

edited

Loading

Upgrade EUI to v88.5.0 #166868

Upgrade EUI to v88.5.0 #166868

Conversation

cee-chen commented Sep 20, 2023 • edited Loading

88.5.0

88.4.1

88.4.0

elasticmachine commented Sep 21, 2023

cee-chen commented Sep 21, 2023

mashhurs left a comment

Choose a reason for hiding this comment

patrykkopycinski commented Sep 27, 2023

kibana-ci commented Sep 27, 2023 • edited Loading

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

Page load bundle

History

jeramysoucy left a comment

Choose a reason for hiding this comment

jbudz commented Sep 27, 2023

michaelolo24 Oct 25, 2023 • edited Loading

Choose a reason for hiding this comment

cee-chen commented Sep 20, 2023 •

edited

Loading

`88.5.0`

`88.4.1`

`88.4.0`

kibana-ci commented Sep 27, 2023 •

edited

Loading

michaelolo24 Oct 25, 2023 •

edited

Loading