Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Adds more tests in unified histogram component #165568

Merged
merged 2 commits into from
Sep 7, 2023
Merged

[ES|QL] Adds more tests in unified histogram component #165568

merged 2 commits into from
Sep 7, 2023

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Sep 4, 2023 •
edited
Loading

Summary

Closes #165431

Adds more unit tests in unified_histogram plugin, as a follow up from ES|QL

Checklist

@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.11.0 labels Sep 4, 2023
@stratoula stratoula marked this pull request as ready for review September 4, 2023 10:28
@stratoula stratoula requested a review from a team as a code owner September 4, 2023 10:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added the Feature:ES|QL ES|QL related features in Kibana label Sep 4, 2023
@stratoula stratoula changed the title [ESQL] Adds more tests in unified histogram component [ES|QL] Adds more tests in unified histogram component Sep 6, 2023
davismcphee
davismcphee approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay lots of new tests 🙌 LGTM, thanks!

@stratoula stratoula merged commit a0404d6 into elastic:main Sep 7, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ES|QL] Add more tests in unified_histogram
5 participants
@stratoula @elasticmachine @kibana-ci @davismcphee @kibanamachine