Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Add more tests in unified_histogram #165431

Closed
stratoula opened this issue Sep 1, 2023 · 2 comments · Fixed by #165568
Closed

[ES|QL] Add more tests in unified_histogram #165431

stratoula opened this issue Sep 1, 2023 · 2 comments · Fixed by #165568
Labels
Feature:ES|QL ES|QL related features in Kibana Feature:UnifiedHistogram Issues related to the Unified Histogram plugin Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. technical debt Improvement of the software architecture and operational architecture

Comments

@stratoula
Copy link
Contributor

stratoula commented Sep 1, 2023 •
edited by davismcphee
Loading

Describe the feature:

Some missing test cases were mentioned on the ES|QL feature branch #146971

At the moment there is no test for the src/plugins/unified_histogram/public/layout/hooks/use_lens_suggestions.ts. It will be good to add some test cases:

  • test when there is no chart
  • test when there are lens suggestions
  • test when there are no lens suggestions but a ESQL histogram is being displayed

We should also add a test case(s) to src/plugins/discover/public/application/main/hooks/use_text_based_query_language.ts to test the difference in behaviour when using or not using transformational commands in ES|QL.
@stratoula stratoula added technical debt Improvement of the software architecture and operational architecture Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:UnifiedHistogram Issues related to the Unified Histogram plugin Feature:ES|QL ES|QL related features in Kibana labels Sep 1, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@stratoula stratoula mentioned this issue Sep 1, 2023
Merged
3 tasks
@davismcphee
Copy link
Contributor

@stratoula Updated to add what I was thinking for use_text_based_query_language.ts, mainly something to test the impact of transformational commands on the hook.

@stratoula stratoula mentioned this issue Sep 4, 2023
Merged
1 task
stratoula added a commit that referenced this issue Sep 7, 2023
@stratoula @kibanamachine
[ES|QL] Adds more tests in unified histogram component (#165568)
a0404d6 
## Summary

Closes #165431

Adds more unit tests in unified_histogram plugin, as a follow up from
ES|QL

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:ES|QL ES|QL related features in Kibana Feature:UnifiedHistogram Issues related to the Unified Histogram plugin Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ES|QL] Adds more tests in unified histogram component stratoula/kibana
3 participants
@elasticmachine @stratoula @davismcphee