Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.10] [Security Solution] Adds new Elastic AI Assistant icon and global header menu item (#164763) #164909

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

kibanamachine
Copy link
Contributor

@kibanamachine kibanamachine commented Aug 26, 2023

Backport

This will backport the following commits from main to 8.10:

Questions ?

Please refer to the Backport tool documentation

…der menu item (elastic#164763)

## Summary

Adds new Elastic AI Assistant logo and global header menu item to all
Security Solution pages.

Resolves elastic/security-team#7407

New logo within the assistant itself (header and assistant avatar):

<p align="center">
<img width="500"
src="https://github.com/elastic/kibana/assets/2946766/2a94c2ca-37d6-49f0-af59-2b15fd37d81e"
/>
</p>

New global header menu for both on-prem and serverless security
`complete` deployments:

<p align="center">
<img width="500"
src="https://github.com/elastic/kibana/assets/2946766/67b030fe-fb36-4a68-9331-d636e15a68f4"
/>
</p>

<p align="center">
<img width="500"
src="https://github.com/elastic/kibana/assets/2946766/74751e3a-a88a-4b39-bec0-73497dcd98b1"
/>
</p>

Note: If Security Assistant RBAC privileges are `NONE` (which includes
serverless deployments that are NOT security `complete`), the global
header button will be hidden. We can revisit the upsell messaging
opportunity here for serverless deployments.

### Checklist

Delete any items that are not applicable to this PR.

- [X] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
* @elastic/security-docs, will need to update images and make note of
new global header item, will create issue...
elastic/security-docs#3804
- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 5cac49a)
@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 28, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #13 / Canvas Canvas app filters handles a conflict match

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 4452 4454 +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/elastic-assistant 63 64 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.7MB 15.7MB +1.1KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/elastic-assistant 4 5 +1
Unknown metric groups

API count

id before after diff
@kbn/elastic-assistant 82 84 +2

ESLint disabled line counts

id before after diff
@kbn/elastic-assistant 18 19 +1

Total ESLint disabled count

id before after diff
@kbn/elastic-assistant 19 20 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @spong

@kibanamachine kibanamachine merged commit eb217d5 into elastic:8.10 Aug 28, 2023
@spong spong changed the title [8.10] [Security Solution] Adds new Elastic AI Assistant logo and global header menu item (#164763) [8.10] [Security Solution] Adds new Elastic AI Assistant icon and global header menu item (#164763) Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants