[Security Solution] Adds new Elastic AI Assistant icon and global header menu item #164763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spong
added
bug
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @spong |
andrew-goldstein
approved these changes
Aug 26, 2023
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 26, 2023
…der menu item (elastic#164763) ## Summary Adds new Elastic AI Assistant logo and global header menu item to all Security Solution pages. Resolves elastic/security-team#7407 New logo within the assistant itself (header and assistant avatar): <p align="center"> <img width="500" src="https://github.com/elastic/kibana/assets/2946766/2a94c2ca-37d6-49f0-af59-2b15fd37d81e" /> </p> New global header menu for both on-prem and serverless security `complete` deployments: <p align="center"> <img width="500" src="https://github.com/elastic/kibana/assets/2946766/67b030fe-fb36-4a68-9331-d636e15a68f4" /> </p> <p align="center"> <img width="500" src="https://github.com/elastic/kibana/assets/2946766/74751e3a-a88a-4b39-bec0-73497dcd98b1" /> </p> Note: If Security Assistant RBAC privileges are `NONE` (which includes serverless deployments that are NOT security `complete`), the global header button will be hidden. We can revisit the upsell messaging opportunity here for serverless deployments. ### Checklist Delete any items that are not applicable to this PR. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials * @elastic/security-docs, will need to update images and make note of new global header item, will create issue... elastic/security-docs#3804 - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 5cac49a)
kibanamachine
added a commit
that referenced
this pull request
Aug 28, 2023
…bal header menu item (#164763) (#164909) # Backport This will backport the following commits from `main` to `8.10`: - [[Security Solution] Adds new Elastic AI Assistant logo and global header menu item (#164763)](#164763) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Garrett Spong","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-26T00:45:43Z","message":"[Security Solution] Adds new Elastic AI Assistant logo and global header menu item (#164763)\n\n## Summary\r\n\r\nAdds new Elastic AI Assistant logo and global header menu item to all\r\nSecurity Solution pages.\r\n\r\nResolves https://github.com/elastic/security-team/issues/7407\r\n\r\nNew logo within the assistant itself (header and assistant avatar):\r\n\r\n<p align=\"center\">\r\n<img width=\"500\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/2a94c2ca-37d6-49f0-af59-2b15fd37d81e\"\r\n/>\r\n</p> \r\n\r\nNew global header menu for both on-prem and serverless security\r\n`complete` deployments:\r\n\r\n<p align=\"center\">\r\n<img width=\"500\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/67b030fe-fb36-4a68-9331-d636e15a68f4\"\r\n/>\r\n</p> \r\n\r\n<p align=\"center\">\r\n<img width=\"500\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/74751e3a-a88a-4b39-bec0-73497dcd98b1\"\r\n/>\r\n</p> \r\n\r\n\r\nNote: If Security Assistant RBAC privileges are `NONE` (which includes\r\nserverless deployments that are NOT security `complete`), the global\r\nheader button will be hidden. We can revisit the upsell messaging\r\nopportunity here for serverless deployments.\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n* @elastic/security-docs, will need to update images and make note of\r\nnew global header item, will create issue...\r\nhttps://github.com/elastic/security-docs/issues/3804\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"5cac49a319371a2341618050e94c03d3591c121c","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","needs_docs","Team: SecuritySolution","Feature:Elastic AI Assistant","v8.10.0","v8.11.0"],"number":164763,"url":"https://github.com/elastic/kibana/pull/164763","mergeCommit":{"message":"[Security Solution] Adds new Elastic AI Assistant logo and global header menu item (#164763)\n\n## Summary\r\n\r\nAdds new Elastic AI Assistant logo and global header menu item to all\r\nSecurity Solution pages.\r\n\r\nResolves https://github.com/elastic/security-team/issues/7407\r\n\r\nNew logo within the assistant itself (header and assistant avatar):\r\n\r\n<p align=\"center\">\r\n<img width=\"500\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/2a94c2ca-37d6-49f0-af59-2b15fd37d81e\"\r\n/>\r\n</p> \r\n\r\nNew global header menu for both on-prem and serverless security\r\n`complete` deployments:\r\n\r\n<p align=\"center\">\r\n<img width=\"500\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/67b030fe-fb36-4a68-9331-d636e15a68f4\"\r\n/>\r\n</p> \r\n\r\n<p align=\"center\">\r\n<img width=\"500\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/74751e3a-a88a-4b39-bec0-73497dcd98b1\"\r\n/>\r\n</p> \r\n\r\n\r\nNote: If Security Assistant RBAC privileges are `NONE` (which includes\r\nserverless deployments that are NOT security `complete`), the global\r\nheader button will be hidden. We can revisit the upsell messaging\r\nopportunity here for serverless deployments.\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n* @elastic/security-docs, will need to update images and make note of\r\nnew global header item, will create issue...\r\nhttps://github.com/elastic/security-docs/issues/3804\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"5cac49a319371a2341618050e94c03d3591c121c"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164763","number":164763,"mergeCommit":{"message":"[Security Solution] Adds new Elastic AI Assistant logo and global header menu item (#164763)\n\n## Summary\r\n\r\nAdds new Elastic AI Assistant logo and global header menu item to all\r\nSecurity Solution pages.\r\n\r\nResolves https://github.com/elastic/security-team/issues/7407\r\n\r\nNew logo within the assistant itself (header and assistant avatar):\r\n\r\n<p align=\"center\">\r\n<img width=\"500\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/2a94c2ca-37d6-49f0-af59-2b15fd37d81e\"\r\n/>\r\n</p> \r\n\r\nNew global header menu for both on-prem and serverless security\r\n`complete` deployments:\r\n\r\n<p align=\"center\">\r\n<img width=\"500\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/67b030fe-fb36-4a68-9331-d636e15a68f4\"\r\n/>\r\n</p> \r\n\r\n<p align=\"center\">\r\n<img width=\"500\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/74751e3a-a88a-4b39-bec0-73497dcd98b1\"\r\n/>\r\n</p> \r\n\r\n\r\nNote: If Security Assistant RBAC privileges are `NONE` (which includes\r\nserverless deployments that are NOT security `complete`), the global\r\nheader button will be hidden. We can revisit the upsell messaging\r\nopportunity here for serverless deployments.\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n* @elastic/security-docs, will need to update images and make note of\r\nnew global header item, will create issue...\r\nhttps://github.com/elastic/security-docs/issues/3804\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"5cac49a319371a2341618050e94c03d3591c121c"}}]}] BACKPORT--> Co-authored-by: Garrett Spong <[email protected]>
spong
changed the title
This was referenced Oct 1, 2023
patrykkopycinski
pushed a commit
that referenced
this pull request
May 16, 2024
) ## Summary This is a fix for showing the license upgrade CTA when using the new flyout experience with the Security Assistant. To test, downgrade your license from `trial` to `basic` in Stack Management and view that the CTA is now back. The `New Chat` and `Expand Conversations` button are now also disabled if `!isAssistantAvailable`. > [!NOTE] > No logic around determining if the assistant should be shown has changed, so all existing tests around `assistantAvailability` are still in place and relevant. This was a surgical fix, and we short-circuit to show this UI if `!isAssistantAvailable`. This is a functional change to ESS only, as Serverless completely hides the assistant when unavailable (`essentials` productTier) as originally implemented in #164763. Before / After: <p align="center"> <img width="300" src="https://github.com/elastic/kibana/assets/2946766/92b512b6-9cec-4f83-948a-d1e101bdc9ec" /> <img width="295" src="https://github.com/elastic/kibana/assets/2946766/c3e39812-27e6-4c4f-ba4c-efb70adff6b5" /> </p>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 16, 2024
…tic#183576) ## Summary This is a fix for showing the license upgrade CTA when using the new flyout experience with the Security Assistant. To test, downgrade your license from `trial` to `basic` in Stack Management and view that the CTA is now back. The `New Chat` and `Expand Conversations` button are now also disabled if `!isAssistantAvailable`. > [!NOTE] > No logic around determining if the assistant should be shown has changed, so all existing tests around `assistantAvailability` are still in place and relevant. This was a surgical fix, and we short-circuit to show this UI if `!isAssistantAvailable`. This is a functional change to ESS only, as Serverless completely hides the assistant when unavailable (`essentials` productTier) as originally implemented in elastic#164763. Before / After: <p align="center"> <img width="300" src="https://github.com/elastic/kibana/assets/2946766/92b512b6-9cec-4f83-948a-d1e101bdc9ec" /> <img width="295" src="https://github.com/elastic/kibana/assets/2946766/c3e39812-27e6-4c4f-ba4c-efb70adff6b5" /> </p> (cherry picked from commit dff2d29)
kibanamachine
referenced
this pull request
May 16, 2024
#183576) (#183583) # Backport This will backport the following commits from `main` to `8.14`: - [[Security Assistant] Show license upgrade CTA within new flyout (#183576)](#183576) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Garrett Spong","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-05-16T04:14:19Z","message":"[Security Assistant] Show license upgrade CTA within new flyout (#183576)\n\n## Summary\r\n\r\nThis is a fix for showing the license upgrade CTA when using the new\r\nflyout experience with the Security Assistant.\r\n\r\nTo test, downgrade your license from `trial` to `basic` in Stack\r\nManagement and view that the CTA is now back.\r\n\r\nThe `New Chat` and `Expand Conversations` button are now also disabled\r\nif `!isAssistantAvailable`.\r\n\r\n> [!NOTE]\r\n> No logic around determining if the assistant should be shown has\r\nchanged, so all existing tests around `assistantAvailability` are still\r\nin place and relevant. This was a surgical fix, and we short-circuit to\r\nshow this UI if `!isAssistantAvailable`.\r\n\r\nThis is a functional change to ESS only, as Serverless completely hides\r\nthe assistant when unavailable (`essentials` productTier) as originally\r\nimplemented in https://github.com/elastic/kibana/pull/164763.\r\n\r\nBefore / After:\r\n<p align=\"center\">\r\n<img width=\"300\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/92b512b6-9cec-4f83-948a-d1e101bdc9ec\"\r\n/> <img width=\"295\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/c3e39812-27e6-4c4f-ba4c-efb70adff6b5\"\r\n/>\r\n</p>","sha":"dff2d294d7083f23cc53b375fba542a89ee38558","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team: SecuritySolution","Feature:Security Assistant","v8.14.0","v8.15.0"],"title":"[Security Assistant] Show license upgrade CTA within new flyout","number":183576,"url":"https://github.com/elastic/kibana/pull/183576","mergeCommit":{"message":"[Security Assistant] Show license upgrade CTA within new flyout (#183576)\n\n## Summary\r\n\r\nThis is a fix for showing the license upgrade CTA when using the new\r\nflyout experience with the Security Assistant.\r\n\r\nTo test, downgrade your license from `trial` to `basic` in Stack\r\nManagement and view that the CTA is now back.\r\n\r\nThe `New Chat` and `Expand Conversations` button are now also disabled\r\nif `!isAssistantAvailable`.\r\n\r\n> [!NOTE]\r\n> No logic around determining if the assistant should be shown has\r\nchanged, so all existing tests around `assistantAvailability` are still\r\nin place and relevant. This was a surgical fix, and we short-circuit to\r\nshow this UI if `!isAssistantAvailable`.\r\n\r\nThis is a functional change to ESS only, as Serverless completely hides\r\nthe assistant when unavailable (`essentials` productTier) as originally\r\nimplemented in https://github.com/elastic/kibana/pull/164763.\r\n\r\nBefore / After:\r\n<p align=\"center\">\r\n<img width=\"300\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/92b512b6-9cec-4f83-948a-d1e101bdc9ec\"\r\n/> <img width=\"295\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/c3e39812-27e6-4c4f-ba4c-efb70adff6b5\"\r\n/>\r\n</p>","sha":"dff2d294d7083f23cc53b375fba542a89ee38558"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/183576","number":183576,"mergeCommit":{"message":"[Security Assistant] Show license upgrade CTA within new flyout (#183576)\n\n## Summary\r\n\r\nThis is a fix for showing the license upgrade CTA when using the new\r\nflyout experience with the Security Assistant.\r\n\r\nTo test, downgrade your license from `trial` to `basic` in Stack\r\nManagement and view that the CTA is now back.\r\n\r\nThe `New Chat` and `Expand Conversations` button are now also disabled\r\nif `!isAssistantAvailable`.\r\n\r\n> [!NOTE]\r\n> No logic around determining if the assistant should be shown has\r\nchanged, so all existing tests around `assistantAvailability` are still\r\nin place and relevant. This was a surgical fix, and we short-circuit to\r\nshow this UI if `!isAssistantAvailable`.\r\n\r\nThis is a functional change to ESS only, as Serverless completely hides\r\nthe assistant when unavailable (`essentials` productTier) as originally\r\nimplemented in https://github.com/elastic/kibana/pull/164763.\r\n\r\nBefore / After:\r\n<p align=\"center\">\r\n<img width=\"300\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/92b512b6-9cec-4f83-948a-d1e101bdc9ec\"\r\n/> <img width=\"295\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/c3e39812-27e6-4c4f-ba4c-efb70adff6b5\"\r\n/>\r\n</p>","sha":"dff2d294d7083f23cc53b375fba542a89ee38558"}}]}] BACKPORT--> Co-authored-by: Garrett Spong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds new Elastic AI Assistant icon and global header menu item to all Security Solution pages.
Resolves https://github.com/elastic/security-team/issues/7407
New icon within the assistant itself (header and assistant avatar):
New global header menu for both on-prem and serverless security
completedeployments:Note: If Security Assistant RBAC privileges are
NONE(which includes serverless deployments that are NOT securitycomplete), the global header button will be hidden. We can revisit the upsell messaging opportunity here for serverless deployments.Checklist
Delete any items that are not applicable to this PR.