Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.9] [Security Solution] Modal says "duplicating 0 rules" when you duplicate an individual rule (#163908) #164687

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

banderror
Copy link
Contributor

Backport

This will backport the following commits from main to 8.9:

Questions ?

Please refer to the Backport tool documentation

…te an individual rule (elastic#163908)

 ## What does this PR do?
 * It fixes the count on the duplicate modal when duplicating an individual rule.

 ## Issue References
Fixes elastic#162035

 ## Video/Screenshot Demo
 ##### Steps to reproduce & Fix:
https://www.loom.com/share/931e42c1490d4483958b8f98dc0ba534?sid=07c67df5-b380-41a5-90f1-f64f326a12d9

___

 This code was written and reviewed by GitStart Community. Growing future engineers, one PR at a time.

(cherry picked from commit 59f2058)
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Defend Workflows Cypress Tests #1 / Endpoint Policy Response from Endpoint List page should display policy response with errors
  • [job] [logs] Defend Workflows Cypress Tests #1 / Endpoint Policy Response from Fleet Agent Details page should display policy response with errors
  • [job] [logs] Explore - Security Solution Tests #2 / Entity Analytics Dashboard With anomalies data enables a job

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.2MB 11.2MB +12.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 416 420 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 497 501 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@banderror banderror merged commit 128fde2 into elastic:8.9 Aug 24, 2023
@banderror banderror deleted the backport/8.9/pr-163908 branch August 24, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants