Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Modal says "duplicating 0 rules" when you duplicate an individual rule #162035

Closed
vgomez-el opened this issue Jul 17, 2023 · 8 comments · Fixed by #163908
Closed

[Security Solution] Modal says "duplicating 0 rules" when you duplicate an individual rule #162035

vgomez-el opened this issue Jul 17, 2023 · 8 comments · Fixed by #163908
Labels
8.10 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management area fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.9.2 v8.10.0

Comments

@vgomez-el
Copy link

Describe the bug:

this bug is an old friend. Re-opening it as it happens again on this version. Rule update counter is not displaying properly the amount of rules to display when updating rules from rule "All Actions" button on Rules table.

Note: It does work properly, when duplicating a single rule from bulk actions. See attached video for more details.

Kibana/Elasticsearch Stack version:

8.9 BC4

Original install method (e.g. download page, yum, from source, etc.):

Cloud deployment

Functional Area (e.g. Endpoint management, timelines, resolver, etc.):

Rules Management table

Steps to reproduce:

  1. Navigate to Rules Management Page
  2. Create any type of custom Rule if there are no rules on Rules table
  3. Click on "All Actions" button
  4. Click on "Duplicate Rule"

Current behavior:

Confirmation Modal message says: "You're duplicating 0 rules. Choose what to duplicate:"

Expected behavior:

Confirmation Modal message should say: "You're duplicating 1 rules. Choose what to duplicate:"

Screenshots (if relevant):

REC-20230717130542.mp4
@vgomez-el vgomez-el added bug Fixes for quality problems that affect the customer experience triage_needed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team labels Jul 17, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@banderror banderror changed the title [Security Solution] Rule update counter is not displaying the amount of rules to display when updating rules from rule "All Actions" button [Security Solution] Modal says "duplicating 0 rules" when you duplicate an individual rule Jul 20, 2023
@banderror banderror added Feature:Rule Management Security Solution Detection Rule Management area and removed triage_needed labels Jul 20, 2023
@banderror banderror removed their assignment Jul 20, 2023
@banderror
Copy link
Contributor

Whoever works on fixing it in the future, please also check the Duplicate action behavior on the Rule Details page.

@gitstart gitstart mentioned this issue Aug 15, 2023
Merged
maximpn pushed a commit that referenced this issue Aug 24, 2023
@gitstart
[Security Solution] Modal says "duplicating 0 rules" when you duplica…
59f2058 
…te an individual rule (#163908)

 ## What does this PR do?
 * It fixes the count on the duplicate modal when duplicating an individual rule.
 
 ## Issue References
Fixes #162035
 
 ## Video/Screenshot Demo
 ##### Steps to reproduce & Fix:
https://www.loom.com/share/931e42c1490d4483958b8f98dc0ba534?sid=07c67df5-b380-41a5-90f1-f64f326a12d9

___
 
 This code was written and reviewed by GitStart Community. Growing future engineers, one PR at a time.
banderror pushed a commit to banderror/kibana that referenced this issue Aug 24, 2023
@gitstart
[Security Solution] Modal says "duplicating 0 rules" when you duplica…
772c109 
…te an individual rule (elastic#163908)

 ## What does this PR do?
 * It fixes the count on the duplicate modal when duplicating an individual rule.

 ## Issue References
Fixes elastic#162035

 ## Video/Screenshot Demo
 ##### Steps to reproduce & Fix:
https://www.loom.com/share/931e42c1490d4483958b8f98dc0ba534?sid=07c67df5-b380-41a5-90f1-f64f326a12d9

___

 This code was written and reviewed by GitStart Community. Growing future engineers, one PR at a time.

(cherry picked from commit 59f2058)
banderror pushed a commit to banderror/kibana that referenced this issue Aug 24, 2023
@gitstart
[Security Solution] Modal says "duplicating 0 rules" when you duplica…
955cbd6 
…te an individual rule (elastic#163908)

 ## What does this PR do?
 * It fixes the count on the duplicate modal when duplicating an individual rule.

 ## Issue References
Fixes elastic#162035

 ## Video/Screenshot Demo
 ##### Steps to reproduce & Fix:
https://www.loom.com/share/931e42c1490d4483958b8f98dc0ba534?sid=07c67df5-b380-41a5-90f1-f64f326a12d9

___

 This code was written and reviewed by GitStart Community. Growing future engineers, one PR at a time.

(cherry picked from commit 59f2058)
@banderror banderror reopened this Aug 24, 2023
@banderror
Copy link
Contributor

@vgomez-el @MadameSheema The fix will be available in the 8.10.0 BC3 and in the 8.9.2 BC. Backports:

banderror added a commit that referenced this issue Aug 24, 2023
@banderror @gitstart
[8.9] [Security Solution] Modal says "duplicating 0 rules" when you d…
128fde2 
…uplicate an individual rule (#163908) (#164687)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[Security Solution] Modal says "duplicating 0 rules" when you
duplicate an individual rule
(#163908)](#163908)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"GitStart","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-24T07:13:17Z","message":"[Security
Solution] Modal says \"duplicating 0 rules\" when you duplicate an
individual rule (#163908)\n\n ## What does this PR do?\r\n * It fixes
the count on the duplicate modal when duplicating an individual
rule.\r\n \r\n ## Issue References\r\nFixes #162035\r\n \r\n ##
Video/Screenshot Demo\r\n ##### Steps to reproduce &
Fix:\r\nhttps://www.loom.com/share/931e42c1490d4483958b8f98dc0ba534?sid=07c67df5-b380-41a5-90f1-f64f326a12d9\r\n\r\n___\r\n
\r\n This code was written and reviewed by GitStart Community. Growing
future engineers, one PR at a
time.","sha":"59f20582605d5dcb489b6534b027ec19475e7136","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","💝community","Team:Detections
and Resp","Team: SecuritySolution","Feature:Rule
Management","Team:Detection Rule
Management","v8.10.0","v8.9.2"],"number":163908,"url":"https://github.com/elastic/kibana/pull/163908","mergeCommit":{"message":"[Security
Solution] Modal says \"duplicating 0 rules\" when you duplicate an
individual rule (#163908)\n\n ## What does this PR do?\r\n * It fixes
the count on the duplicate modal when duplicating an individual
rule.\r\n \r\n ## Issue References\r\nFixes #162035\r\n \r\n ##
Video/Screenshot Demo\r\n ##### Steps to reproduce &
Fix:\r\nhttps://www.loom.com/share/931e42c1490d4483958b8f98dc0ba534?sid=07c67df5-b380-41a5-90f1-f64f326a12d9\r\n\r\n___\r\n
\r\n This code was written and reviewed by GitStart Community. Growing
future engineers, one PR at a
time.","sha":"59f20582605d5dcb489b6534b027ec19475e7136"}},"sourceBranch":"main","suggestedTargetBranches":["8.10","8.9"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.9","label":"v8.9.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: GitStart <[email protected]>
banderror added a commit that referenced this issue Aug 24, 2023
@banderror @gitstart
[8.10] [Security Solution] Modal says "duplicating 0 rules" when you …
93d4f66 
…duplicate an individual rule (#163908) (#164686)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Security Solution] Modal says "duplicating 0 rules" when you
duplicate an individual rule
(#163908)](#163908)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"GitStart","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-24T07:13:17Z","message":"[Security
Solution] Modal says \"duplicating 0 rules\" when you duplicate an
individual rule (#163908)\n\n ## What does this PR do?\r\n * It fixes
the count on the duplicate modal when duplicating an individual
rule.\r\n \r\n ## Issue References\r\nFixes #162035\r\n \r\n ##
Video/Screenshot Demo\r\n ##### Steps to reproduce &
Fix:\r\nhttps://www.loom.com/share/931e42c1490d4483958b8f98dc0ba534?sid=07c67df5-b380-41a5-90f1-f64f326a12d9\r\n\r\n___\r\n
\r\n This code was written and reviewed by GitStart Community. Growing
future engineers, one PR at a
time.","sha":"59f20582605d5dcb489b6534b027ec19475e7136","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","💝community","Team:Detections
and Resp","Team: SecuritySolution","Feature:Rule
Management","Team:Detection Rule
Management","v8.10.0","v8.9.2"],"number":163908,"url":"https://github.com/elastic/kibana/pull/163908","mergeCommit":{"message":"[Security
Solution] Modal says \"duplicating 0 rules\" when you duplicate an
individual rule (#163908)\n\n ## What does this PR do?\r\n * It fixes
the count on the duplicate modal when duplicating an individual
rule.\r\n \r\n ## Issue References\r\nFixes #162035\r\n \r\n ##
Video/Screenshot Demo\r\n ##### Steps to reproduce &
Fix:\r\nhttps://www.loom.com/share/931e42c1490d4483958b8f98dc0ba534?sid=07c67df5-b380-41a5-90f1-f64f326a12d9\r\n\r\n___\r\n
\r\n This code was written and reviewed by GitStart Community. Growing
future engineers, one PR at a
time.","sha":"59f20582605d5dcb489b6534b027ec19475e7136"}},"sourceBranch":"main","suggestedTargetBranches":["8.10","8.9"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.9","label":"v8.9.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: GitStart <[email protected]>
@MadameSheema
Copy link
Member

Tested on latest 8.10.0 branch (c3a088b) and the fix is working fine.

Validated:

  • Duplication of 1 rule
  • Bulk duplicate when you have more than 1 rule selected
  • Bulk duplicate when you have all the rules displayed of the page selected
  • Bulk duplicate when you have all the created rules selected

@karanbirsingh-qasource please validate the same scenarios on next BC. Thanks!

@ghost
Copy link

ghost commented Aug 25, 2023

ok @MadameSheema

@vgomez-el
Copy link
Author

vgomez-el commented Aug 31, 2023 •
edited
Loading

Hi all,
The bugs is fixed for 8.10 BC3 version.

REC-20230831170628.mp4

Still pending to get the 8.9.2 version available on Cloud, to check the fix there, before labeling it as Validated

@vgomez-el
Copy link
Author

Hi all, the bug is fixed for 8.9.2 version too:

REC-20230901112652.mp4

I will mark the bug as validated since it is fixed for 8.10 and 8.9.2 versions.

@vgomez-el vgomez-el added the QA:Validated Issue has been validated by QA label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
8.10 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management area fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.9.2 v8.10.0
Projects
None yet
Milestone
No milestone
4 participants
@banderror @elasticmachine @MadameSheema @vgomez-el