Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.10] [Security Solution] Expandable flyout - update flyout header (#164514) #164597

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.10:

Questions ?

Please refer to the Backport tool documentation

…#164514)

## Summary

This PR addresses a name mismatch mentioned in
elastic#164398.

- Flyout header in non-alerts page are updated to "Event details" to
match previous flyout header
- Fixed timestamp position to align with header

Before

![image](https://github.com/elastic/kibana/assets/18648970/b718beac-74d2-40fd-baf9-9c59aad6a46a)

After

![image](https://github.com/elastic/kibana/assets/18648970/1e9b4e5a-ac18-4d8a-a732-458811942d1a)

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 3b6c2c2)
@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 23, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Explore - Security Solution Cypress Tests #1 / Cases Creates a new case with timeline and opens the timeline Creates a new case with timeline and opens the timeline

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.7MB 15.7MB +18.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @christineweng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants