[Security Solution] Expandable flyout - update flyout header #164514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christineweng
added
release_note:skip
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
PhilippeOberti
approved these changes
Aug 22, 2023
| </h4> | ||
| </EuiTitle> | ||
| <EuiSpacer size="s" /> | ||
| <EuiFlexGroup direction="row" gutterSize="m"> | ||
| <EuiFlexGroup direction="row" gutterSize={isAlert ? 'm' : 'none'}> |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 23, 2023
…#164514) ## Summary This PR addresses a name mismatch mentioned in elastic#164398. - Flyout header in non-alerts page are updated to "Event details" to match previous flyout header - Fixed timestamp position to align with header Before  After  ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 3b6c2c2)
kibanamachine
added a commit
that referenced
this pull request
Aug 23, 2023
…164514) (#164597) # Backport This will backport the following commits from `main` to `8.10`: - [[Security Solution] Expandable flyout - update flyout header (#164514)](#164514) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-23T14:26:53Z","message":"[Security Solution] Expandable flyout - update flyout header (#164514)\n\n## Summary\r\n\r\nThis PR addresses a name mismatch mentioned in\r\nhttps://github.com//issues/164398.\r\n\r\n- Flyout header in non-alerts page are updated to \"Event details\" to\r\nmatch previous flyout header\r\n- Fixed timestamp position to align with header\r\n\r\nBefore\r\n\r\n\r\n\r\nAfter\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"3b6c2c2429726c423d12fb97537ed10927d3f1fa","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting","Team:Threat Hunting:Investigations","v8.10.0","v8.11.0"],"number":164514,"url":"https://github.com/elastic/kibana/pull/164514","mergeCommit":{"message":"[Security Solution] Expandable flyout - update flyout header (#164514)\n\n## Summary\r\n\r\nThis PR addresses a name mismatch mentioned in\r\nhttps://github.com//issues/164398.\r\n\r\n- Flyout header in non-alerts page are updated to \"Event details\" to\r\nmatch previous flyout header\r\n- Fixed timestamp position to align with header\r\n\r\nBefore\r\n\r\n\r\n\r\nAfter\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"3b6c2c2429726c423d12fb97537ed10927d3f1fa"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164514","number":164514,"mergeCommit":{"message":"[Security Solution] Expandable flyout - update flyout header (#164514)\n\n## Summary\r\n\r\nThis PR addresses a name mismatch mentioned in\r\nhttps://github.com//issues/164398.\r\n\r\n- Flyout header in non-alerts page are updated to \"Event details\" to\r\nmatch previous flyout header\r\n- Fixed timestamp position to align with header\r\n\r\nBefore\r\n\r\n\r\n\r\nAfter\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"3b6c2c2429726c423d12fb97537ed10927d3f1fa"}}]}] BACKPORT--> Co-authored-by: christineweng <[email protected]>
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a name mismatch mentioned in #164398.
Before
After
Checklist
Delete any items that are not applicable to this PR.