[Infra UI] Fix filter popovers not being closed on trigger button click #164060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykolaharmash
added
Feature:Metrics UI
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
mykolaharmash
changed the title
mykolaharmash
added
v8.10.0
backport:prev-minor
|
@elasticmachine merge upstream |
mykolaharmash
force-pushed
the
96534-fix-stuck-inventory-filter-popovers
branch
from
56c3d26 to
5b6bf60
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
mykolaharmash
commented
Aug 17, 2023
| @@ -197,6 +197,10 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { | |||
| await pageObjects.infraHome.openTimeline(); | |||
| await pageObjects.infraHome.closeTimeline(); | |||
| }); | |||
|
|
|||
| it('toggles the inventory switcher', async () => { | |||
There was a problem hiding this comment.
Added this one test just to get familiar with the testing setup.
crespocarlos
approved these changes
Aug 17, 2023
Comment on lines
33
to
+34
| const closePopover = useCallback(() => setIsOpen(false), []); | ||
| const openPopover = useCallback(() => setIsOpen(true), []); | ||
| const togglePopover = useCallback(() => setIsOpen((currentIsOpen) => !currentIsOpen), []); |
There was a problem hiding this comment.
Just FYI, there is a custom hook that could be used here. ex:
const [isPopoverOpen, { off: closePopover, toggle: togglePopover }] = useBoolean(false);Mentioning it for the future, if you come across anything that might be interesting to use it.
There was a problem hiding this comment.
Nice, thank you! 👍
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 17, 2023
…ck (elastic#164060) Fixes elastic#96534 ## Summary Fixes the bug with some popovers are not closed if their trigger buttons are clicked *Bug demos from the original issue* Inventory:  Metrics Explorer  ### How to test * Checkout the branch locally * Goto "Inventory" section * Click on "Hosts" filter * Make sure popover opens * Click on "Hosts" again * Make sure the popover closes * Check the same for "Sort by" filter * Check the same for chart "Actions" in "Metrics Explorer" (cherry picked from commit c8083dd)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 17, 2023
…ton click (#164060) (#164143) # Backport This will backport the following commits from `main` to `8.10`: - [[Infra UI] Fix filter popovers not being closed on trigger button click (#164060)](#164060) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mykola Harmash","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-17T09:05:32Z","message":"[Infra UI] Fix filter popovers not being closed on trigger button click (#164060)\n\nFixes #96534 \r\n\r\n## Summary\r\n\r\nFixes the bug with some popovers are not closed if their trigger buttons\r\nare clicked\r\n\r\n*Bug demos from the original issue*\r\nInventory:\r\n\r\n\r\nMetrics Explorer\r\n\r\n\r\n\r\n### How to test\r\n\r\n* Checkout the branch locally\r\n* Goto \"Inventory\" section\r\n* Click on \"Hosts\" filter\r\n* Make sure popover opens\r\n* Click on \"Hosts\" again\r\n* Make sure the popover closes\r\n* Check the same for \"Sort by\" filter\r\n* Check the same for chart \"Actions\" in \"Metrics Explorer\"","sha":"c8083dd6767a88f15379531319b5636d20e79451","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Metrics UI","Team:Infra Monitoring UI","release_note:skip","backport:prev-minor","v8.11.0"],"number":164060,"url":"https://github.com/elastic/kibana/pull/164060","mergeCommit":{"message":"[Infra UI] Fix filter popovers not being closed on trigger button click (#164060)\n\nFixes #96534 \r\n\r\n## Summary\r\n\r\nFixes the bug with some popovers are not closed if their trigger buttons\r\nare clicked\r\n\r\n*Bug demos from the original issue*\r\nInventory:\r\n\r\n\r\nMetrics Explorer\r\n\r\n\r\n\r\n### How to test\r\n\r\n* Checkout the branch locally\r\n* Goto \"Inventory\" section\r\n* Click on \"Hosts\" filter\r\n* Make sure popover opens\r\n* Click on \"Hosts\" again\r\n* Make sure the popover closes\r\n* Check the same for \"Sort by\" filter\r\n* Check the same for chart \"Actions\" in \"Metrics Explorer\"","sha":"c8083dd6767a88f15379531319b5636d20e79451"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Mykola Harmash <[email protected]>
\r\nMetrics){kind=link}
\r\n\r\n###){kind=link}
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96534
Summary
Fixes the bug with some popovers are not closed if their trigger buttons are clicked
Bug demos from the original issue
Inventory:
Metrics Explorer
How to test