Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics] Bug: Inventory - The "sort by" control popover gets stuck, no way to dismiss #96534

Closed
formgeist opened this issue Apr 8, 2021 · 3 comments · Fixed by #164060
Closed

[Metrics] Bug: Inventory - The "sort by" control popover gets stuck, no way to dismiss #96534

formgeist opened this issue Apr 8, 2021 · 3 comments · Fixed by #164060
Assignees
@mykolaharmash
Labels
bug Fixes for quality problems that affect the customer experience Feature:Metrics UI Metrics UI feature Feature:ObsInventory good first issue low hanging fruit Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.0.0

Comments

@formgeist
Copy link
Contributor

Kibana version: master
Browser: Chrome 89.0.4389.114

Summary

It seems the popover that is shown when clicking the Sort by control in the Inventory view gets stuck and there's no other way to dismiss than to select an option in the list.

2021-04-08 at 9 40 07 - Jade Crab
@formgeist formgeist added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Apr 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@formgeist
Copy link
Contributor Author

I found another case of non-dismissable popovers on the Actions popover in Metrics Explorer. Not sure if this is a new problem with the Eui component or the implementation in Metrics?

2021-04-08 at 9 52 23 - Pink Aardvark

@miltonhultgren miltonhultgren added the Feature:Metrics UI Metrics UI feature label Jun 23, 2023
@roshan-elastic
Copy link

Prioritising low - we're unlikely to invest in Inventory in the short/medium-term

@crespocarlos crespocarlos added the good first issue low hanging fruit label Aug 15, 2023
@mykolaharmash mykolaharmash mentioned this issue Aug 16, 2023
Merged
mykolaharmash added a commit that referenced this issue Aug 17, 2023
@mykolaharmash
[Infra UI] Fix filter popovers not being closed on trigger button cli…
c8083dd 
…ck (#164060)

Fixes #96534 

## Summary

Fixes the bug with some popovers are not closed if their trigger buttons
are clicked

*Bug demos from the original issue*
Inventory:

![](https://user-images.githubusercontent.com/4104278/113987390-a222e900-984e-11eb-872b-f12f5abe4540.gif)
Metrics Explorer

![](https://user-images.githubusercontent.com/4104278/113988929-3b9eca80-9850-11eb-859a-c639b89af8a5.gif)

### How to test

* Checkout the branch locally
* Goto "Inventory" section
* Click on "Hosts" filter
* Make sure popover opens
* Click on "Hosts" again
* Make sure the popover closes
* Check the same for "Sort by" filter
* Check the same for chart "Actions"  in "Metrics Explorer"
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Aug 17, 2023
@mykolaharmash
[Infra UI] Fix filter popovers not being closed on trigger button cli…
fa4988d 
…ck (elastic#164060)

Fixes elastic#96534

## Summary

Fixes the bug with some popovers are not closed if their trigger buttons
are clicked

*Bug demos from the original issue*
Inventory:

![](https://user-images.githubusercontent.com/4104278/113987390-a222e900-984e-11eb-872b-f12f5abe4540.gif)
Metrics Explorer

![](https://user-images.githubusercontent.com/4104278/113988929-3b9eca80-9850-11eb-859a-c639b89af8a5.gif)

### How to test

* Checkout the branch locally
* Goto "Inventory" section
* Click on "Hosts" filter
* Make sure popover opens
* Click on "Hosts" again
* Make sure the popover closes
* Check the same for "Sort by" filter
* Check the same for chart "Actions"  in "Metrics Explorer"

(cherry picked from commit c8083dd)
kibanamachine added a commit that referenced this issue Aug 17, 2023
@kibanamachine @mykolaharmash
[8.10] [Infra UI] Fix filter popovers not being closed on trigger but…
69667f3 
…ton click (#164060) (#164143)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Infra UI] Fix filter popovers not being closed on trigger button
click (#164060)](#164060)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Mykola
Harmash","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-17T09:05:32Z","message":"[Infra
UI] Fix filter popovers not being closed on trigger button click
(#164060)\n\nFixes #96534 \r\n\r\n## Summary\r\n\r\nFixes the bug with
some popovers are not closed if their trigger buttons\r\nare
clicked\r\n\r\n*Bug demos from the original
issue*\r\nInventory:\r\n\r\n![](https://user-images.githubusercontent.com/4104278/113987390-a222e900-984e-11eb-872b-f12f5abe4540.gif)\r\nMetrics
Explorer\r\n\r\n![](https://user-images.githubusercontent.com/4104278/113988929-3b9eca80-9850-11eb-859a-c639b89af8a5.gif)\r\n\r\n###
How to test\r\n\r\n* Checkout the branch locally\r\n* Goto \"Inventory\"
section\r\n* Click on \"Hosts\" filter\r\n* Make sure popover opens\r\n*
Click on \"Hosts\" again\r\n* Make sure the popover closes\r\n* Check
the same for \"Sort by\" filter\r\n* Check the same for chart
\"Actions\" in \"Metrics
Explorer\"","sha":"c8083dd6767a88f15379531319b5636d20e79451","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Metrics
UI","Team:Infra Monitoring
UI","release_note:skip","backport:prev-minor","v8.11.0"],"number":164060,"url":"https://github.com/elastic/kibana/pull/164060","mergeCommit":{"message":"[Infra
UI] Fix filter popovers not being closed on trigger button click
(#164060)\n\nFixes #96534 \r\n\r\n## Summary\r\n\r\nFixes the bug with
some popovers are not closed if their trigger buttons\r\nare
clicked\r\n\r\n*Bug demos from the original
issue*\r\nInventory:\r\n\r\n![](https://user-images.githubusercontent.com/4104278/113987390-a222e900-984e-11eb-872b-f12f5abe4540.gif)\r\nMetrics
Explorer\r\n\r\n![](https://user-images.githubusercontent.com/4104278/113988929-3b9eca80-9850-11eb-859a-c639b89af8a5.gif)\r\n\r\n###
How to test\r\n\r\n* Checkout the branch locally\r\n* Goto \"Inventory\"
section\r\n* Click on \"Hosts\" filter\r\n* Make sure popover opens\r\n*
Click on \"Hosts\" again\r\n* Make sure the popover closes\r\n* Check
the same for \"Sort by\" filter\r\n* Check the same for chart
\"Actions\" in \"Metrics
Explorer\"","sha":"c8083dd6767a88f15379531319b5636d20e79451"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Mykola Harmash <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mykolaharmash mykolaharmash

Labels
bug Fixes for quality problems that affect the customer experience Feature:Metrics UI Metrics UI feature Feature:ObsInventory good first issue low hanging fruit Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Infra UI] Fix filter popovers not being closed on trigger button click mykolaharmash/kibana
6 participants
@mykolaharmash @miltonhultgren @crespocarlos @formgeist @elasticmachine @roshan-elastic