Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] wait for action button to be present before clicking to fix flacky FTR tests #164054

Merged
merged 14 commits into from
Aug 22, 2023
Merged

[Cloud Security] wait for action button to be present before clicking to fix flacky FTR tests #164054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1954ed8
wait for action button to be present before clicking to fix flacky FT…
maxcold Aug 16, 2023
1483acb
trying retry.try
maxcold Aug 16, 2023
60f917e
try clickAndValidate approach
maxcold Aug 16, 2023
bd5b891
drop clickAndValidate
maxcold Aug 16, 2023
dbd13e2
manually check for navigation to happen in retry
maxcold Aug 16, 2023
fdbff36
add wait for integration page to be loaded before checking for the he…
maxcold Aug 16, 2023
bd212e4
move the logic into shared method
maxcold Aug 16, 2023
3b58d35
clean up
maxcold Aug 16, 2023
d5a1cd6
remove comment about the failing build
maxcold Aug 16, 2023
20ec2ec
removed unused getService param
maxcold Aug 21, 2023
52cfc89
Merge branch 'main' into 155657-fix-onboarding-ftr-tests
kibanamachine Aug 21, 2023
128b503
Merge branch 'main' into 155657-fix-onboarding-ftr-tests
maxcold Aug 21, 2023
776f0a7
Merge branch 'main' into 155657-fix-onboarding-ftr-tests
maxcold Aug 21, 2023
59494bb
Merge branch 'main' into 155657-fix-onboarding-ftr-tests
maxcold Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions x-pack/test/cloud_security_posture_functional/page_objects/findings_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const FINDINGS_LATEST_INDEX = 'logs-cloud_security_posture.findings_latest-defau

export function FindingsPageProvider({ getService, getPageObjects }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const PageObjects = getPageObjects(['common']);
const PageObjects = getPageObjects(['common', 'header']);
const retry = getService('retry');
const es = getService('es');
const supertest = getService('supertest');
Expand Down Expand Up @@ -92,7 +92,15 @@ export function FindingsPageProvider({ getService, getPageObjects }: FtrProvider
},

async navigateToAction(actionTestSubject: string) {
await testSubjects.click(actionTestSubject);
return await retry.try(async () => {
await testSubjects.click(actionTestSubject);
await PageObjects.header.waitUntilLoadingHasFinished();
const result = await testSubjects.exists('createPackagePolicy_pageTitle');

if (!result) {
throw new Error('Integration installation page not found');
}
});
},
});

Expand Down
5 changes: 3 additions & 2 deletions x-pack/test/cloud_security_posture_functional/pages/findings_onboarding.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ import { FtrProviderContext } from '../ftr_provider_context';
export default ({ getPageObjects }: FtrProviderContext) => {
const PageObjects = getPageObjects(['common', 'findings', 'header']);

// Failing: See https://github.com/elastic/kibana/issues/163950
describe.skip('Findings Page onboarding', function () {
describe('Findings Page onboarding', function () {
this.tags(['cloud_security_posture_findings_onboarding']);
let findings: typeof PageObjects.findings;
let notInstalledVulnerabilities: typeof findings.notInstalledVulnerabilities;
Expand All @@ -34,6 +33,7 @@ export default ({ getPageObjects }: FtrProviderContext) => {
expect(element).to.not.be(null);

await notInstalledVulnerabilities.navigateToAction('cnvm-not-installed-action');

await PageObjects.common.waitUntilUrlIncludes('add-integration/vuln_mgmt');
});

Expand All @@ -44,6 +44,7 @@ export default ({ getPageObjects }: FtrProviderContext) => {
expect(element).to.not.be(null);

await notInstalledCSP.navigateToAction('cspm-not-installed-action');

await PageObjects.common.waitUntilUrlIncludes('add-integration/cspm');
});

Expand Down