[Cloud Security] wait for action button to be present before clicking to fix flacky FTR tests #164054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxcold
force-pushed
the
155657-fix-onboarding-ftr-tests
branch
from
175fa4b to
3b58d35
Compare
maxcold
added
release_note:skip
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
JordanSh
approved these changes
Aug 21, 2023
| @@ -9,11 +9,10 @@ import expect from '@kbn/expect'; | |||
| import { FtrProviderContext } from '../ftr_provider_context'; | |||
|
|
|||
| // eslint-disable-next-line import/no-default-export | |||
| export default ({ getPageObjects }: FtrProviderContext) => { | |||
| export default ({ getPageObjects, getService }: FtrProviderContext) => { | |||
There was a problem hiding this comment.
getService doesn't seem to be in use
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing flaky FTR test where we need to navigate to the integrations page from our onboarding views. Confirmed in the flaky test runner that with the fix tests are not flaky anymore https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2901
fixes:
No integrations installedprompt action button -install CNVM: navigates to the CNVM integration installation page #163950