Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly wait for search list to load, fix flaky test #16388

Merged
merged 1 commit into from
Jan 30, 2018
Merged

Properly wait for search list to load, fix flaky test #16388

merged 1 commit into from
Jan 30, 2018

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Jan 30, 2018

This fixes a flaky test about lab visualization. The test failure can be seen in this build.

Apparently the list of saved searches haven't open properly before the element were tried to be found (looking at the screenshot). Since the loading indicator is used while opening the list, we now wait for it to finish.

@timroes timroes added bug Fixes for quality problems that affect the customer experience test Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Jan 30, 2018
@timroes timroes requested a review from ppisljar January 30, 2018 10:20
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes
Copy link
Contributor Author

timroes commented Jan 30, 2018

Jenkins, test this

First run succeeded. Let's try another one.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes
Copy link
Contributor Author

timroes commented Jan 30, 2018

Jenkins, test this

Second run succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@bhavyarm bhavyarm assigned bhavyarm and unassigned bhavyarm Jan 30, 2018
@bhavyarm bhavyarm self-requested a review January 30, 2018 14:34
bhavyarm
bhavyarm approved these changes Jan 30, 2018
View reviewed changes
Copy link
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timroes timroes merged commit 9979f10 into elastic:master Jan 30, 2018
@timroes timroes deleted the fix-flaky-lab-test branch January 30, 2018 14:35
@timroes timroes mentioned this pull request Jan 30, 2018
Merged
timroes added a commit to timroes/kibana that referenced this pull request Jan 30, 2018
@timroes
Properly wait for search list to load (elastic#16388)
ed7b895
timroes added a commit to timroes/kibana that referenced this pull request Jan 30, 2018
@timroes
Properly wait for search list to load (elastic#16388)
a3cd5ea
@timroes timroes mentioned this pull request Jan 30, 2018
Merged
timroes added a commit that referenced this pull request Jan 30, 2018
@timroes
[6.x] Fix issue with disabled lab mode (#16351) | Properly wait for s…
eceb08d 
…earch list to load (#16388) (#16394)

* Fix issue with disabled lab mode (#16351)

* Fix saved object finder issue

* Add functional test

* Properly wait for search list to load (#16388)
timroes added a commit that referenced this pull request Jan 30, 2018
@timroes
[6.2] Fix issue with disabled lab mode (#16351) (#16395)
2ff20dc 
* Fix issue with disabled lab mode (#16351)

* Fix saved object finder issue

* Add functional test

* Properly wait for search list to load (#16388)

* Apply patch for 6.2 branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhavyarm bhavyarm bhavyarm approved these changes

@ppisljar ppisljar Awaiting requested review from ppisljar

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timroes @elasticmachine @bhavyarm