Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with disabled lab mode #16351

Merged
merged 2 commits into from
Jan 30, 2018

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Jan 29, 2018

This PR fixes an issue where you cannot load saved searches, embed them into dashboards, load timelion sheets, etc. while visualize:enableLabs is turned off in advanced settings.

Fix #16349

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@timroes timroes added bug Fixes for quality problems that affect the customer experience release_note:fix v7.0.0 v6.2.0 v6.3.0 labels Jan 29, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes timroes merged commit 232b267 into elastic:master Jan 30, 2018
@timroes timroes deleted the fix-saved-object-finder branch January 30, 2018 08:56
timroes added a commit to timroes/kibana that referenced this pull request Jan 30, 2018
* Fix saved object finder issue

* Add functional test
timroes added a commit to timroes/kibana that referenced this pull request Jan 30, 2018
* Fix saved object finder issue

* Add functional test
timroes added a commit to timroes/kibana that referenced this pull request Jan 30, 2018
* Fix saved object finder issue

* Add functional test
timroes added a commit to timroes/kibana that referenced this pull request Jan 30, 2018
* Fix saved object finder issue

* Add functional test
timroes added a commit that referenced this pull request Jan 30, 2018
…earch list to load (#16388) (#16394)

* Fix issue with disabled lab mode (#16351)

* Fix saved object finder issue

* Add functional test

* Properly wait for search list to load (#16388)
timroes added a commit that referenced this pull request Jan 30, 2018
* Fix issue with disabled lab mode (#16351)

* Fix saved object finder issue

* Add functional test

* Properly wait for search list to load (#16388)

* Apply patch for 6.2 branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Fixes for quality problems that affect the customer experience release_note:fix v6.2.0 v6.3.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot load saved searches with lab modes disabled
4 participants