Adjust global loading indicator data-test-subj for projects #163697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pheyos
added
release_note:skip
2 tasks
tsullivan
approved these changes
Aug 11, 2023
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @pheyos |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 11, 2023
…163697) ## Summary This PR adjusts the `data-test-subj` for the global loading indicator in serverless projects such that at matches the stateful version. This makes sure that functional tests and corresponding test helper methods continue to work the same in stateful and serverless environments when comes to waiting for global loading to finish, which is a key mechanism to avoid test flakiness. ### Additional information - The serverless project specific global loading indicator was introduced with elastic#158523 - The stateful loading indicator `data-test-subj` naming is implemented here: https://github.com/elastic/kibana/blob/main/packages/core/chrome/core-chrome-browser-internal/src/ui/loading_indicator.tsx#L61 Co-authored-by: Tim Sullivan <[email protected]> (cherry picked from commit fd08c62)
kibanamachine
added a commit
that referenced
this pull request
Aug 11, 2023
…63697) (#163745) # Backport This will backport the following commits from `main` to `8.9`: - [Adjust global loading indicator data-test-subj for projects (#163697)](#163697) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Robert Oskamp","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-11T17:40:26Z","message":"Adjust global loading indicator data-test-subj for projects (#163697)\n\n## Summary\r\n\r\nThis PR adjusts the `data-test-subj` for the global loading indicator in\r\nserverless projects such that at matches the stateful version. This\r\nmakes sure that functional tests and corresponding test helper methods\r\ncontinue to work the same in stateful and serverless environments when\r\ncomes to waiting for global loading to finish, which is a key mechanism\r\nto avoid test flakiness.\r\n\r\n### Additional information\r\n\r\n- The serverless project specific global loading indicator was\r\nintroduced with #158523\r\n- The stateful loading indicator `data-test-subj` naming is implemented\r\nhere:\r\nhttps://github.com/elastic/kibana/blob/main/packages/core/chrome/core-chrome-browser-internal/src/ui/loading_indicator.tsx#L61\r\n\r\nCo-authored-by: Tim Sullivan <[email protected]>","sha":"fd08c62f052d065e677b670a381840ae80dc9724","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v8.10.0","v8.9.1"],"number":163697,"url":"https://github.com/elastic/kibana/pull/163697","mergeCommit":{"message":"Adjust global loading indicator data-test-subj for projects (#163697)\n\n## Summary\r\n\r\nThis PR adjusts the `data-test-subj` for the global loading indicator in\r\nserverless projects such that at matches the stateful version. This\r\nmakes sure that functional tests and corresponding test helper methods\r\ncontinue to work the same in stateful and serverless environments when\r\ncomes to waiting for global loading to finish, which is a key mechanism\r\nto avoid test flakiness.\r\n\r\n### Additional information\r\n\r\n- The serverless project specific global loading indicator was\r\nintroduced with #158523\r\n- The stateful loading indicator `data-test-subj` naming is implemented\r\nhere:\r\nhttps://github.com/elastic/kibana/blob/main/packages/core/chrome/core-chrome-browser-internal/src/ui/loading_indicator.tsx#L61\r\n\r\nCo-authored-by: Tim Sullivan <[email protected]>","sha":"fd08c62f052d065e677b670a381840ae80dc9724"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163697","number":163697,"mergeCommit":{"message":"Adjust global loading indicator data-test-subj for projects (#163697)\n\n## Summary\r\n\r\nThis PR adjusts the `data-test-subj` for the global loading indicator in\r\nserverless projects such that at matches the stateful version. This\r\nmakes sure that functional tests and corresponding test helper methods\r\ncontinue to work the same in stateful and serverless environments when\r\ncomes to waiting for global loading to finish, which is a key mechanism\r\nto avoid test flakiness.\r\n\r\n### Additional information\r\n\r\n- The serverless project specific global loading indicator was\r\nintroduced with #158523\r\n- The stateful loading indicator `data-test-subj` naming is implemented\r\nhere:\r\nhttps://github.com/elastic/kibana/blob/main/packages/core/chrome/core-chrome-browser-internal/src/ui/loading_indicator.tsx#L61\r\n\r\nCo-authored-by: Tim Sullivan <[email protected]>","sha":"fd08c62f052d065e677b670a381840ae80dc9724"}},{"branch":"8.9","label":"v8.9.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Oskamp <[email protected]>
|
This pr didn't make it into the build candidate for v8.9.1. Updating the labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adjusts the
data-test-subjfor the global loading indicator in serverless projects such that at matches the stateful version. This makes sure that functional tests and corresponding test helper methods continue to work the same in stateful and serverless environments when comes to waiting for global loading to finish, which is a key mechanism to avoid test flakiness.Additional information
data-test-subjnaming is implemented here: https://github.com/elastic/kibana/blob/main/packages/core/chrome/core-chrome-browser-internal/src/ui/loading_indicator.tsx#L61