-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cases] Handle lens actions in Serverless #163581
[Cases] Handle lens actions in Serverless #163581
Conversation
Pinging @elastic/response-ops (Team:ResponseOps) |
Pinging @elastic/response-ops-cases (Feature:Cases) |
…-ref HEAD~1..HEAD --fix'
Tested a bunch of scenarios:
|
x-pack/test_serverless/functional/test_suites/observability/cases/attachment_framework.ts
Show resolved
Hide resolved
const availableOwners = useAvailableCasesOwners(); | ||
const canShowCaseSolutionSelection = !owner.length && availableOwners.length; | ||
const canShowCaseSolutionSelection = !owner.length && availableOwners.length > 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will slightly change the behavior of the form when going through Analytics in Classic Kibana.
There there is no owner
and the availableOwners
can be 1(depending on the role's permissions). This will make it not show the owner picker(your PR) vs showing the owner picker with all options disabled except one(main).
It is a specific scenario so maybe it is not a problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm..The only way to handle this could be to add another config variable which tells weather it is serverless or classic kibana and then put the check accordingly.
However I think it's okay to not show owner selector picker when only one owner
because we don't show it anyway when it's a security solution dashboard and user has permission for cases in security in classic kibana.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but there we don't show because we are in Security Solution. The owner is defined and it is safe to assume the created case will end up inside Security Solution.
In the scenario I mentioned, we start from Analytics
. The user has no indication of where the case will end up.
(Although he can assume if he only has access to like, Observability 😄 )
I think this is minor though. Maybe double-check with @mdefazio ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with hiding this if there is only one solution available. Thanks for double checking on this. @shanisagiv1 Let me know if you're ok with hiding this solution selector (and if you would like some more context to this, happy to zoom 😉 )
x-pack/test_serverless/functional/test_suites/observability/cases/attachment_framework.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff 👌
x-pack/test_serverless/functional/test_suites/security/ftr/cases/helper/api.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
fixes #160126
This PR
How to test
Checklist
Delete any items that are not applicable to this PR.
For maintainers