[Security Solution] Unskip rules table auto-refresh Cypress tests

[maximpn]

Addresses: #154694

Summary

This PR unskips rules table auto-refresh tests.

Details

Rules table auto-refresh Cypress tests were outdated so it was hard to determine the original flakiness reason. To make it working the following has been done

• mockGlobalClock() moved above visit() to mock the time before visiting the page. It didn't look like working so the test had to wait for 60 seconds (our refresh interval)
• removed unnecessary waiting waitForRulesTableToBeLoaded() as the test should work without it
• removed setRowsPerPageTo(5) as the test doesn't look related to the page size
• AutoRefreshButtonComponent was refactored in attempt to fix popover closing related flakiness but it doesn't seem to help but the refactoring looks improving readability so leaving as a part of this PR
• auto-refresh popover's behavior has been changed. The trigger button gets disabled if there is a rule selected. Clicking the disabled button won't make the auto-refresh popover to appear so this part was changed.

Encountered issues

• EuiPopover should close by clicking the trigger button, clicking outside or pressing Esc button. The latter two cause flakiness for some reason. I spent quite some time to investigate the reason but without success. It looks like there is a race condition related to EuiFocusTrap but it doesn't look to be an issue outside Cypress.
• waitForRulesTableToBeLoaded() basically does nothing after changes in the rules table. Looking at tis contents

export const waitForRulesTableToBeLoaded = () => {
  // Wait up to 5 minutes for the rules to load as in CI containers this can be very slow
  cy.get(RULES_TABLE_INITIAL_LOADING_INDICATOR, { timeout: 300000 }).should('not.exist');
};

reveals that RULES_TABLE_INITIAL_LOADING_INDICATOR defined as [data-test-subj="initialLoadingPanelAllRulesTable"] doesn't exist anymore in our codebase so this function instantly returns. The selector will be fixed in a separate PR.

• invoking mockGlobalClock() during the test leads to appearing a lot of Executing a cancelled action error messages.

Flaky test runner

50 runs succeeded

[elasticmachine]

Pinging @elastic/security-detections-response (Team:Detections and Resp)

[elasticmachine]

Pinging @elastic/security-solution (Team: SecuritySolution)

[jpdjere]

Don't forget to undo this change

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: a06ddb3

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
securitySolution	15.6MB	15.6MB	+14.0B

History

• 💚 Build #149137 succeeded 443a04b
• 💔 Build #149125 failed bc18d4bdb28c55cbe59fa29de8bd8eab4b9504c0
• 💔 Build #148557 failed b36d45b6e2a6ed47980cc86df1d6152fa456cdb5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maximpn

[jpdjere]

LGTM 👍

And thanks for the refactor of the AutoRefreshButtonComponent component. It sure is more readable now.

[kibanamachine]

💔 All backports failed

Status	Branch	Result
❌	8.9	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 163451

Questions ?

Please refer to the Backport tool documentation

[banderror]

@maximpn @jpdjere ^^^ It looks like backporting fixes of flakiness is going to be difficult because of changes in the tests folder structure. Do you think we could still backport or apply fixes manually to the 8.9 branch, or would it be too much effort?

[jpdjere]

@maximpn @banderror Up to now the PRs to fix flakiness have been relatively small, I think we can apply the fixes manually or even cherry-pick the commits, in some cases.

WDYT Maxim?