[Security Solution] expandable flyout - replace feature flag with advanced settings toggle #161614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
release_note:enhancement
Team:Threat Hunting:Investigations
PhilippeOberti
force-pushed
the
expanded-flyout-6640
branch
2 times, most recently
from
6b19840 to
cda4659
Compare
PhilippeOberti
force-pushed
the
expanded-flyout-6640
branch
8 times, most recently
from
3cd9180 to
e4e46bc
Compare
PhilippeOberti
force-pushed
the
expanded-flyout-6640
branch
8 times, most recently
from
48608c5 to
cd5fde6
Compare
PhilippeOberti
commented
Aug 9, 2023
| @@ -29,7 +29,7 @@ import { login, visit } from '../../tasks/login'; | |||
|
|
|||
| import { ALERTS_URL } from '../../urls/navigation'; | |||
|
|
|||
| describe('Enrichment', () => { | |||
| describe.skip('Enrichment', () => { | |||
There was a problem hiding this comment.
this test has been failing for the last few builds and also fails locally
There was a problem hiding this comment.
Could you please create a ticket similar to this one #162818 and put there details about skipped test and link to the failing builkite job? Thanks!
There was a problem hiding this comment.
ticket created!
There was a problem hiding this comment.
@PhilippeOberti I was thinking more about this and was wondering if this test is failing only on your PR? If that is the case and the test is not failing on main then I would say we should figure out why these changes cause this test to fail and fix it instead of skipping.
There was a problem hiding this comment.
thanks for coming back to this. I spent a bit more time and was able to actually fix the test. It was NOT flaky. I guess I was confused the first time.
The test is now unskipped and fixed. I also closed the ticket I opened. Sorry!
PhilippeOberti
force-pushed
the
expanded-flyout-6640
branch
from
cd5fde6 to
9261acf
Compare
Files by Code Ownerelastic/kibana-core
elastic/kibana-telemetry
elastic/security-defend-workflows
elastic/security-detection-engine
elastic/security-solution
elastic/security-threat-hunting-explore
elastic/security-threat-hunting-investigations
|
tomsonpl
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Defend Workflows LGTM 🚀
Great to see the flyout getting GA :)
But regarding specyfing response_actions to run only on old flyout - I think it would be great to also mirror the tests in the new flyout since it's gonna be enabled by default. Would you have some time to do that? If it's problematic I can help, just tell me if I should commit directly here, or wait until you merge?
Once again, great work, thanks for doing this 👍
thanks @tomsonpl! I didn't mirror the tests is because I'm not super familiar with how the response details tab was implemented. Looking at my growing list of things to do before feature freeze I'm really not sure I would have time to write the new tests. Also, I have 2 more PRs waiting for this one to be merged, so it would be a lot less stressful to get this in first, if that is ok with everyone of course! |
e40pud
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
DE changes LGTM!
Two comments:
- Could you add ticket for the skipped test?
- Would be great if you can run affected tests against "flaky test runner". Here is the doc about the runner.
| @@ -29,7 +29,7 @@ import { login, visit } from '../../tasks/login'; | |||
|
|
|||
| import { ALERTS_URL } from '../../urls/navigation'; | |||
|
|
|||
| describe('Enrichment', () => { | |||
| describe.skip('Enrichment', () => { | |||
There was a problem hiding this comment.
Could you please create a ticket similar to this one #162818 and put there details about skipped test and link to the failing builkite job? Thanks!
christineweng
approved these changes
Aug 10, 2023
PhilippeOberti
force-pushed
the
expanded-flyout-6640
branch
2 times, most recently
from
60e21fe to
bded134
Compare
PhilippeOberti
force-pushed
the
expanded-flyout-6640
branch
from
bded134 to
a93a319
Compare
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
|
Hi Philippe, I ran the branch and was able to enable/disable the new flyout via advance settings 👍 . But I found some unexpected error when clicking the sub-tabs (correlations especially) under insight tab. Could you please try if you can reproduce this? I created a rule with host.name: *, generated alerts and clicked on one of it. Expanded the details and clicked on each tab. Screen.Recording.2023-08-11.at.12.57.38.movAnother test video: |
Hey @angorayc, thanks for reviewing! This is a known issue and I have a draft PR fixing it, as well as a few more PRs making small changes to the new flyout. This current PR is only to change the feature flag to an advanced settings :) |
angorayc
approved these changes
Aug 11, 2023
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 11, 2023
* main: (64 commits) [ML] Transforms: Fix privileges check. (elastic#163687) [Log Explorer] Add test suite for Dataset Selector (elastic#163079) [Security Solution][Endpoint] Add API checks to Endpoint Policy create/update for checking `endpointPolicyProtections` is enabled (elastic#163429) [Security Solution] Fix flaky test: x-pack/test/detection_engine_api_integration/security_and_spaces/update_prebuilt_rules_package/update_prebuilt_rules_package·ts - update_prebuilt_rules_package should allow user to install prebuilt rules from scratch, then install new rules and upgrade existing rules from the new package (elastic#163241) [Security Solution] expandable flyout - replace feature flag with advanced settings toggle (elastic#161614) [DOCS] Adds the release notes for the 8.9.1 release. (elastic#163578) [FTR] Implement browser network condition utils (elastic#163633) [Security Solution] Unskip rules table auto-refresh Cypress tests (elastic#163451) [Security Solution] Re-enable fixed rule snoozing Cypress test (elastic#160037) [Flaky Test elastic#111821] Mock `moment` to avoid midnight TZ issues (elastic#163157) Document interactive setup (elastic#163619) [Lens] Align decoration color with text color for layer actions (elastic#163630) [Lens] Relax counter field checks for saved visualizations with unsupported operations (elastic#163515) [Security Solution][Endpoint] Removes pMap and uses a for loop instead (elastic#163509) [Enterprise Search] Update Workplace Search connectors doclink (elastic#163676) Update APM (main) (elastic#163623) [Serverless] Partially fix lens/maps/visualize breadcrumbs missing title (elastic#163476) [Flaky elastic#118272] Unskip tests (elastic#163319) [APM] Make service group saved objects exportable (elastic#163569) [Observability AI Assistant] Action menu item (elastic#163463) ...
patrykkopycinski
added a commit
that referenced
this pull request
Aug 16, 2023
## Summary Adjust tests to #161614 Split tests into smaller files to better utilize parallelization and increase the stability of tests
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 18, 2023
## Summary Adjust tests to elastic#161614 Split tests into smaller files to better utilize parallelization and increase the stability of tests (cherry picked from commit fd33ed5)
kibanamachine
referenced
this pull request
Aug 18, 2023
# Backport This will backport the following commits from `main` to `8.10`: - [Fix osquery cypress tests (#163988)](#163988) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Patryk Kopyciński","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-16T22:11:05Z","message":"Fix osquery cypress tests (#163988)\n\n## Summary\r\n\r\nAdjust tests to https://github.com/elastic/kibana/pull/161614\r\nSplit tests into smaller files to better utilize parallelization and\r\nincrease the stability of tests","sha":"fd33ed55fd9bc81d006ca41c85b7bd4117741e80","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v8.10.0","v8.11.0"],"number":163988,"url":"https://github.com/elastic/kibana/pull/163988","mergeCommit":{"message":"Fix osquery cypress tests (#163988)\n\n## Summary\r\n\r\nAdjust tests to https://github.com/elastic/kibana/pull/161614\r\nSplit tests into smaller files to better utilize parallelization and\r\nincrease the stability of tests","sha":"fd33ed55fd9bc81d006ca41c85b7bd4117741e80"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163988","number":163988,"mergeCommit":{"message":"Fix osquery cypress tests (#163988)\n\n## Summary\r\n\r\nAdjust tests to https://github.com/elastic/kibana/pull/161614\r\nSplit tests into smaller files to better utilize parallelization and\r\nincrease the stability of tests","sha":"fd33ed55fd9bc81d006ca41c85b7bd4117741e80"}},{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Patryk Kopyciński <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are going GA with the new Expandable Flyout in Security Solution in 8.10. We still want to allow users to use the old flyout.
Until now we were allowing users to switch to the new flyout by modifying the
kibana.ymllike soxpack.securitySolution.enableExperimental: ['securityFlyoutEnabled']Using a toggle within the
Stack Management=>Advanced Settingspage under theSecurity Solutionsection is a lot more user friendly.This PR replaces the feature flag experimental feature by an advanced settings toggle.
The new advanced settings toggle is set to
trueby default.Screen.Recording.2023-07-11.at.8.33.31.AM.mov
Primary changes:
securitySolution:enableExpandableFlyoutadvanced settings and removesecurityFlyoutEnabledfeature flag8.11or8.12)https://github.com/elastic/security-team/issues/6641