Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure "View rule in Kibana" Url for Observability rule types #163292

Merged
merged 12 commits into from
Aug 11, 2023

Conversation

maryam-saeidi
Copy link
Member

Closes #163168

Summary

This PR configures the "View rule in Kibana" URL to point to the observability rule details for observability rule types.

image

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@maryam-saeidi maryam-saeidi changed the title 162890 view rule in kibana Configure "View rule in Kibana" Url for Observability rule types Aug 7, 2023
@maryam-saeidi maryam-saeidi self-assigned this Aug 7, 2023
@maryam-saeidi maryam-saeidi added the release_note:skip Skip the PR/issue when compiling release notes label Aug 7, 2023
@maryam-saeidi maryam-saeidi marked this pull request as ready for review August 7, 2023 14:36
@maryam-saeidi maryam-saeidi requested review from a team as code owners August 7, 2023 14:36
Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Aug 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Aug 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 501 502 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 58.8KB 58.8KB +82.0B
Unknown metric groups

API count

id before after diff
observability 508 509 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

@maryam-saeidi maryam-saeidi merged commit feb2493 into elastic:main Aug 11, 2023
@maryam-saeidi maryam-saeidi deleted the 162890-view-rule-in-kibana branch August 11, 2023 07:09
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AO] Configure "View rule in Kibana" Url
8 participants