Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify getViewInAppRelativeUrl configuration #164254

Open
maryam-saeidi opened this issue Aug 19, 2023 · 1 comment
Open

Simplify getViewInAppRelativeUrl configuration #164254

maryam-saeidi opened this issue Aug 19, 2023 · 1 comment
Labels
discuss Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@maryam-saeidi
Copy link
Member

maryam-saeidi commented Aug 19, 2023

📝 Summary

Currently, getViewInAppRelativeUrl is configured at the rule registration level (example). This logic is exactly the same for all the observability rules as shown below:

The current implementation in observability, as done in this PR, seems a bit repetitive and unnecessary, especially since there are few solutions to cover. Also, it will make rule creation harder by having more configurations.

✨ Improvement

Given the fact that we only have a limited number of apps with their own rule details page (Stack, Observability, Security), I was wondering if, instead of configuring this function for each rule separately, it would be possible to decide which rule details page to show based on an existing parameter in the rule.

📔 Side note

I noticed that in the security solution, they also include time while creating the rule details URL, so maybe we can have a default implementation for accessing the rule details page in each app and override it only if it is needed.

@maryam-saeidi maryam-saeidi added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Aug 19, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
Development

No branches or pull requests

3 participants