-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES_UI Shared] Migrate all usages of EuiPage*_Deprecated #163136
Conversation
Co-authored-by: LuisChiej <[email protected]> Co-authored-by: gitstart_bot <[email protected]>
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Hi @gitstart! Thank you for your contribution ❤️ Can you please provide screenshots of the changes you have made? This will help us greatly with the review and confirm the changes have been tested. Also - a quick note: While the “How” section in #161413 provides a quick conversion map, unfortunately, this does not work for all cases. Please refer to the EUI guidelines on how to approach the migration and examples. You can also take a look at this PR as a reference implementation: #163134. Please let us know if you have any questions. Thanks! |
Co-authored-by: LuisChiej <[email protected]> Co-authored-by: gitstart_bot <[email protected]>
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
Co-authored-by: LuisChiej <[email protected]> Co-authored-by: gitstart_bot <[email protected]>
@alisonelizabeth. Ready for review |
Co-authored-by: LuisChiej <[email protected]> Co-authored-by: gitstart_bot <[email protected]>
@alisonelizabeth. Can you give us a guide to trace the screenshots on this particular PR?. It's ready for review too |
@elasticmachine merge upstream |
buildkite test this |
I can help with testing on this one, as these are shared components used across several plugins. |
@elasticmachine run elasticsearch-ci/docs |
buildkite test this |
@elasticmachine run elasticsearch-ci/docs |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this PR do?
Issue References
Fixes #163018
Video/Screenshot Demo
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.