Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES_UI Shared] Migrate all usages of EuiPage*_Deprecated #163136

Merged
merged 10 commits into from
Aug 23, 2023

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Aug 4, 2023

What does this PR do?

  • Migrate all usages of EuiPage*_Deprecated in ES_UI Shared

Issue References

Fixes #163018

Video/Screenshot Demo


This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@gitstart gitstart changed the title ELS-174 - [ES_UI Shared] Migrate all usages of EuiPage*_Deprecated [ES_UI Shared] Migrate all usages of EuiPage*_Deprecated Aug 4, 2023
@gitstart gitstart marked this pull request as ready for review August 4, 2023 01:38
@gitstart gitstart requested a review from a team as a code owner August 4, 2023 01:38
@alisonelizabeth
Copy link
Contributor

Hi @gitstart! Thank you for your contribution ❤️

Can you please provide screenshots of the changes you have made? This will help us greatly with the review and confirm the changes have been tested.

Also - a quick note: While the “How” section in #161413 provides a quick conversion map, unfortunately, this does not work for all cases. Please refer to the EUI guidelines on how to approach the migration and examples. You can also take a look at this PR as a reference implementation: #163134.

Please let us know if you have any questions. Thanks!

@yuliacech yuliacech added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes labels Aug 17, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@gitstart
Copy link
Contributor Author

@alisonelizabeth. Ready for review

@gitstart
Copy link
Contributor Author

@alisonelizabeth. Can you give us a guide to trace the screenshots on this particular PR?. It's ready for review too

@alisonelizabeth
Copy link
Contributor

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor

buildkite test this

@alisonelizabeth
Copy link
Contributor

@alisonelizabeth. Can you give us a guide to trace the screenshots on this particular PR?. It's ready for review too

I can help with testing on this one, as these are shared components used across several plugins.

@alisonelizabeth
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@alisonelizabeth
Copy link
Contributor

buildkite test this

@alisonelizabeth
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 523.6KB 523.6KB -31.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
esUiShared 156.5KB 156.3KB -175.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Thanks @gitstart! I added the color="danger" prop to the PageError component and also removed an unnecessary data-test-subj attribute in ab851b0.

@alisonelizabeth alisonelizabeth merged commit 841c56c into elastic:main Aug 23, 2023
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting 💝community release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ES_UI Shared] Migrate all usages of EuiPage*_Deprecated
6 participants