[Index Management] Migrate all usages of EuiPage*_Deprecated #163133
Conversation
Co-authored-by: LuisChiej <[email protected]> Co-authored-by: gitstart_bot <[email protected]>
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
gitstart
changed the title
|
Hi @gitstart! Thank you for your contribution ❤️ Can you please provide screenshots of the changes you have made? This will help us greatly with the review and confirm the changes have been tested. Also - a quick note: While the “How” section in #161413 provides a quick conversion map, unfortunately, this does not work for all cases. Please refer to the EUI guidelines on how to approach the migration and examples. You can also take a look at this PR as a reference implementation: #163134. Please let us know if you have any questions. Thanks! |
Co-authored-by: LuisChiej <[email protected]> Co-authored-by: gitstart_bot <[email protected]>
|
@elasticmachine merge upstream |
alisonelizabeth
added
Team:Kibana Management
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
There was a problem hiding this comment.
Hi @gitstart - thanks for your contribution! I have one suggestion on improvements to index_table.js. Please take a look. Thanks!
| > | ||
| {renderNoContent()} | ||
| </EuiPageContent> | ||
| {renderNoContent()} |
There was a problem hiding this comment.
I would suggest cleaning the code up a bit, starting on L437:
if (!hasContent) {
if (indicesLoading) {
return (
<PageLoading>
<FormattedMessage
id="xpack.idxMgmt.indexTable.loadingIndicesDescription"
defaultMessage="Loading indices…"
/>
</PageLoading>
);
}
if (indicesError) {
if (indicesError.status === 403) {
return (
<PageError
title={
<FormattedMessage
id="xpack.idxMgmt.pageErrorForbidden.title"
defaultMessage="You do not have permissions to use Index Management"
/>
}
/>
);
}
return (
<PageError
title={
<FormattedMessage
id="xpack.idxMgmt.indexTable.serverErrorTitle"
defaultMessage="Error loading indices"
/>
}
error={indicesError.body}
/>
);
}
}
There was a problem hiding this comment.
Note (not actionable, but for awareness): PageLoading and PageError both come from es_us_shared. Changes will be needed here as well, but should be addressed as part of #163136
|
buildkite test this |
|
@gitstart please also review the CI failures in #163133 (comment) |
Co-authored-by: LuisChiej <[email protected]> Co-authored-by: gitstart_bot <[email protected]>
|
@elasticmachine merge upstream |
|
buildkite test this |
|
@elasticmachine run elasticsearch-ci/docs |
|
@elasticmachine merge upstream |
|
buildkite test this |
|
@elasticmachine run elasticsearch-ci/docs |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.11.0
backport:skip
What does this PR do?
Issue References
Video/Screenshot Demo
x-pack/plugins/index_management/public/application/sections/home/data_stream_list/data_stream_list.tsxx-pack/plugins/index_management/public/application/sections/home/index_list/index_table/index_table.jsx-pack/plugins/index_management/public/application/components/component_templates/component_template_wizard/component_template_edit/component_template_edit.tsxx-pack/plugins/index_management/public/application/components/component_templates/component_template_wizard/component_template_create/component_template_create.tsxThis code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.