Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security solution] Fixing console errors #163119

Merged
merged 20 commits into from
Aug 16, 2023
Merged

[Security solution] Fixing console errors #163119

merged 20 commits into from
Aug 16, 2023

Conversation

stephmilovic
Copy link
Contributor

Summary

Fixes a variety of console errors. Errors are described in the file changes.

@stephmilovic stephmilovic added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore labels Aug 3, 2023
stephmilovic
stephmilovic commented Aug 3, 2023
View reviewed changes
x-pack/plugins/security_solution/public/timelines/components/fields_browser/index.tsx
const fetchAndSetDataView = async (dataViewId: string) => {
const aDatView = await dataViews.get(dataViewId);
if (ignore) return;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes:
c3

stephmilovic
stephmilovic commented Aug 7, 2023
View reviewed changes
...ck/plugins/security_solution/public/common/components/events_viewer/use_timelines_events.tsx
@@ -392,6 +378,13 @@ export const useTimelineEventsHandler = ({
filterStatus,
]);

useEffect(() => {
if (timelineResponse.totalCount > -1) {
setUpdated(timelineResponse.updatedAt);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes:
d1

stephmilovic
stephmilovic commented Aug 7, 2023
View reviewed changes
...-elastic-assistant/impl/assistant/prompt_editor/system_prompt/select_system_prompt/index.tsx
@@ -91,7 +91,7 @@ const SelectSystemPromptComponent: React.FC<Props> = ({
dropdownDisplay: (
<EuiFlexGroup gutterSize="none" key={ADD_NEW_SYSTEM_PROMPT}>
<EuiFlexItem grow={true}>
<EuiButtonEmpty iconType="plus" size="xs" data-test-subj="addSystemPrompt">
<EuiButtonEmpty href="#" iconType="plus" size="xs" data-test-subj="addSystemPrompt">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes:
d2

stephmilovic
stephmilovic commented Aug 9, 2023
View reviewed changes
x-pack/packages/kbn-elastic-assistant/impl/connectorland/connector_selector/index.tsx
@@ -76,7 +76,7 @@ export const ConnectorSelector: React.FC<Props> = React.memo(
dropdownDisplay: (
<EuiFlexGroup gutterSize="none" key={ADD_NEW_CONNECTOR}>
<EuiFlexItem grow={true}>
<EuiButtonEmpty iconType="plus" size="xs">
<EuiButtonEmpty href="#" iconType="plus" size="xs">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes:
a1

stephmilovic
stephmilovic commented Aug 11, 2023
View reviewed changes
x-pack/plugins/security_solution/public/timelines/containers/index.tsx

useEffect(() => {
if (timelineResponse.updatedAt !== 0) {
setUpdated(timelineResponse.updatedAt);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes:
e1a
e1b

stephmilovic
stephmilovic commented Aug 15, 2023
View reviewed changes
x-pack/packages/security-solution/navigation/src/landing_links/landing_links_images_cards.tsx
{description}
</EuiText>
}
titleElement="span"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes:
c1

stephmilovic
stephmilovic commented Aug 15, 2023
View reviewed changes
x-pack/packages/security-solution/navigation/src/landing_links/landing_links_images_cards.tsx
</EuiText>
}
titleElement="span"
description={<span css={styles.description}>{description}</span>}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes:
c2

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Cypress Tests #1 / Add/edit exception from rule details existing list and items Edits an exception item Edits an exception item
  • [job] [logs] Security Solution Cypress Tests #6 / Custom query rules Custom detection rules deletion and edition Deletion Deletes one rule from detail page Deletes one rule from detail page

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.6MB 15.6MB +579.0B
securitySolutionServerless 255.3KB 255.3KB -5.0B
total +574.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic stephmilovic marked this pull request as ready for review August 16, 2023 17:30
@stephmilovic stephmilovic requested review from a team as code owners August 16, 2023 17:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

YulNaumenko
YulNaumenko approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@stephmilovic stephmilovic merged commit 2d2975f into elastic:main Aug 16, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephmilovic @kibana-ci @elasticmachine @YulNaumenko @kibanamachine