[Security solution] Fixing console errors (#163119)

elastic · Aug 16, 2023 · 2d2975f · 2d2975f
1 parent bf6aefe
commit 2d2975f
Show file tree

Hide file tree

Showing 6 changed files with 26 additions and 33 deletions.
diff --git a/...astic-assistant/impl/assistant/prompt_editor/system_prompt/select_system_prompt/index.tsx b/...astic-assistant/impl/assistant/prompt_editor/system_prompt/select_system_prompt/index.tsx
@@ -91,7 +91,7 @@ const SelectSystemPromptComponent: React.FC<Props> = ({
       dropdownDisplay: (
         <EuiFlexGroup gutterSize="none" key={ADD_NEW_SYSTEM_PROMPT}>
           <EuiFlexItem grow={true}>
-            <EuiButtonEmpty iconType="plus" size="xs" data-test-subj="addSystemPrompt">
+            <EuiButtonEmpty href="#" iconType="plus" size="xs" data-test-subj="addSystemPrompt">
               {i18n.ADD_NEW_SYSTEM_PROMPT}
             </EuiButtonEmpty>
           </EuiFlexItem>

diff --git a/x-pack/packages/kbn-elastic-assistant/impl/connectorland/connector_selector/index.tsx b/x-pack/packages/kbn-elastic-assistant/impl/connectorland/connector_selector/index.tsx
@@ -76,7 +76,7 @@ export const ConnectorSelector: React.FC<Props> = React.memo(
         dropdownDisplay: (
           <EuiFlexGroup gutterSize="none" key={ADD_NEW_CONNECTOR}>
             <EuiFlexItem grow={true}>
-              <EuiButtonEmpty iconType="plus" size="xs">
+              <EuiButtonEmpty href="#" iconType="plus" size="xs">
                 {i18n.ADD_NEW_CONNECTOR}
               </EuiButtonEmpty>
             </EuiFlexItem>

diff --git a/...ck/packages/security-solution/navigation/src/landing_links/landing_links_images_cards.tsx b/...ck/packages/security-solution/navigation/src/landing_links/landing_links_images_cards.tsx
@@ -4,15 +4,7 @@
  * 2.0; you may not use this file except in compliance with the Elastic License
  * 2.0.
  */
-import {
-  EuiCard,
-  EuiFlexGroup,
-  EuiFlexItem,
-  EuiImage,
-  EuiText,
-  EuiTitle,
-  useEuiTheme,
-} from '@elastic/eui';
+import { EuiCard, EuiFlexGroup, EuiFlexItem, EuiImage, EuiTitle, useEuiTheme } from '@elastic/eui';
 import React from 'react';
 import { css } from '@emotion/react';
 import { withLink } from '../links';
@@ -96,11 +88,8 @@ export const LandingLinksImageCards: React.FC<LandingLinksImagesProps> = React.m
                     {isBeta && <BetaBadge text={betaOptions?.text} />}
                   </div>
                 }
-                description={
-                  <EuiText size="s" color="text" css={styles.description}>
-                    {description}
-                  </EuiText>
-                }
+                titleElement="span"
+                description={<span css={styles.description}>{description}</span>}
               />
             </EuiFlexItem>
           );

diff --git a/...plugins/security_solution/public/common/components/events_viewer/use_timelines_events.tsx b/...plugins/security_solution/public/common/components/events_viewer/use_timelines_events.tsx
@@ -261,8 +261,6 @@ export const useTimelineEventsHandler = ({
                       totalCount: response.totalCount,
                       updatedAt: Date.now(),
                     };
-                    setUpdated(newTimelineResponse.updatedAt);
-                    setTotalCount(newTimelineResponse.totalCount);
                     if (onNextHandler) onNextHandler(newTimelineResponse);
                     return newTimelineResponse;
                   });
@@ -294,19 +292,7 @@ export const useTimelineEventsHandler = ({
       asyncSearch();
       refetch.current = asyncSearch;
     },
-    [
-      skip,
-      data,
-      setTotalCount,
-      entityType,
-      dataViewId,
-      setUpdated,
-      addWarning,
-      startTracking,
-      dispatch,
-      id,
-      prevFilterStatus,
-    ]
+    [skip, data, entityType, dataViewId, addWarning, startTracking, dispatch, id, prevFilterStatus]
   );
 
   useEffect(() => {
@@ -392,6 +378,13 @@ export const useTimelineEventsHandler = ({
     filterStatus,
   ]);
 
+  useEffect(() => {
+    if (timelineResponse.totalCount > -1) {
+      setUpdated(timelineResponse.updatedAt);
+      setTotalCount(timelineResponse.totalCount);
+    }
+  }, [setTotalCount, setUpdated, timelineResponse]);
+
   const timelineEventsSearchHandler = useCallback(
     (onNextHandler?: OnNextResponseHandler) => {
       if (!deepEqual(prevTimelineRequest.current, timelineRequest)) {

diff --git a/x-pack/plugins/security_solution/public/timelines/components/fields_browser/index.tsx b/x-pack/plugins/security_solution/public/timelines/components/fields_browser/index.tsx
@@ -63,13 +63,19 @@ export const useFieldBrowserOptions: UseFieldBrowserOptions = ({
     scopeIdSelector(state, sourcererScope)
   );
   useEffect(() => {
+    let ignore = false;
     const fetchAndSetDataView = async (dataViewId: string) => {
       const aDatView = await dataViews.get(dataViewId);
+      if (ignore) return;
       setDataView(aDatView);
     };
     if (selectedDataViewId != null && !missingPatterns.length) {
       fetchAndSetDataView(selectedDataViewId);
     }
+
+    return () => {
+      ignore = true;
+    };
   }, [selectedDataViewId, missingPatterns, dataViews]);
 
   const openFieldEditor = useCallback<OpenFieldEditor>(

diff --git a/x-pack/plugins/security_solution/public/timelines/containers/index.tsx b/x-pack/plugins/security_solution/public/timelines/containers/index.tsx
@@ -214,6 +214,13 @@ export const useTimelineEventsHandler = ({
     loadPage: wrappedLoadPage,
     updatedAt: 0,
   });
+
+  useEffect(() => {
+    if (timelineResponse.updatedAt !== 0) {
+      setUpdated(timelineResponse.updatedAt);
+    }
+  }, [setUpdated, timelineResponse.updatedAt]);
+
   const { addWarning } = useAppToasts();
 
   const timelineSearch = useCallback(
@@ -252,7 +259,6 @@ export const useTimelineEventsHandler = ({
                     totalCount: response.totalCount,
                     updatedAt: Date.now(),
                   };
-                  setUpdated(newTimelineResponse.updatedAt);
                   if (id === TimelineId.active) {
                     activeTimeline.setExpandedDetail({});
                     activeTimeline.setPageName(pageName);
@@ -336,7 +342,6 @@ export const useTimelineEventsHandler = ({
       startTracking,
       data.search,
       dataViewId,
-      setUpdated,
       addWarning,
       refetchGrid,
       wrappedLoadPage,