Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Remove deprecated EuiPage usages in EDR Workflows pages #162531

Merged
merged 18 commits into from
Sep 13, 2023
Merged

[Security Solution] Remove deprecated EuiPage usages in EDR Workflows pages #162531

merged 18 commits into from
Sep 13, 2023

Conversation

kevinlog
Copy link
Contributor

@kevinlog kevinlog commented Jul 25, 2023 •
edited
Loading

Summary

Updated our deprecated usages of EuiPageTemplate with the new components.

Addresses this ticket: #161405

Below see the affected components after applying the new components

Administration/Endpoint List

image

Policy error

image

Policy details

image

Artifacts in policy

image

No artifacts in policy

image

No artifacts assigned in policy

image

Empty artifact page

image

Artifact page

image

Empty Endpoint and Policy pages

image image

@kevinlog
Copy link
Contributor Author

@elasticmachine merge upstream

@kevinlog kevinlog added Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.11.0 release_note:skip Skip the PR/issue when compiling release notes labels Aug 25, 2023
@kevinlog
Copy link
Contributor Author

@elasticmachine merge upstream

@kevinlog kevinlog marked this pull request as ready for review August 28, 2023 12:30
@kevinlog kevinlog requested review from a team as code owners August 28, 2023 12:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

ashokaditya
ashokaditya approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. 🚢 it!

@kevinlog
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #45 / Advanced Settings security feature controls global advanced_settings all privileges "after all" hook for "doesn't show read-only badge"
  • [job] [logs] FTR Configs #4 / Profiling API tests feature_controls.spec.ts cloud Loading profiling data Profiling feature controls returns ok for users with access to profiling APIs

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.6MB 12.6MB -264.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kevinlog kevinlog merged commit b35328f into elastic:main Sep 13, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 13, 2023
@kevinlog kevinlog deleted the task/migrate-deprecated-EuiPage branch September 13, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashokaditya ashokaditya ashokaditya approved these changes

@paul-tavares paul-tavares paul-tavares approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kevinlog @elasticmachine @kibana-ci @ashokaditya @paul-tavares @kibanamachine