Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Migrate all usages of EuiPage*_Deprecated #161405

Closed
Tracked by #161872
cee-chen opened this issue Jul 6, 2023 · 3 comments
Closed
Tracked by #161872

[Security Solution] Migrate all usages of EuiPage*_Deprecated #161405

cee-chen opened this issue Jul 6, 2023 · 3 comments
Assignees
@kevinlog
Labels
deprecation_warnings EUI OLM Sprint Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@cee-chen
Copy link
Member

cee-chen commented Jul 6, 2023 •
edited
Loading

👋 Hello from your friendly neighborhood EUI team! It's been almost a year since EUI's new EuiPageTemplate came out (if you can believe it), which means we're about a month away from the old deprecated EUI page template components being permanently removed.

Your team is being pinged in this issue because you have 7 usages of EuiPage*_Deprecated components, which you can find listed here:

https://github.com/search?q=repo%3Aelastic%2Fkibana+%2FEuiPage%5Ba-zA-Z%5D%2B_Deprecated%2F+path%3A%2F%5Ex-pack%5C%2Fplugins%5C%2Fsecurity_solution%2F&type=code

How

  • Please see our new EuiPageTemplate guidelines and examples for suggestions on how to migrate over.
  • You can also see more examples of layout conversions in the original EuiPageTemplate PR:
    [Feature] EuiPage and EuiPageTemplate Updates eui#5768
  • Here's a quick conversion map of components that approximately translate to their new equivalents:
    • EuiPageTemplate_Deprecated -> EuiPageTemplate
    • EuiPageSideBar_Deprecated -> EuiPageSidebar or EuiPageTemplate.Sidebar
    • EuiPageContent_Deprecated -> EuiPageSection or EuiPageTemplate.Section
    • EuiPageContentBody_Deprecated -> Use EuiPageSection instead
    • EuiPageContentHeader_Deprecated -> Use EuiPageHeader instead
    • EuiPageContentHeaderSection_Deprecated -> Use EuiPageHeader instead

When

We'd really appreciate it if you could migrate your component usages over before or during August if possible.

If your team does not have the ability or bandwidth to perform this work by that time, please let us know. While we'd really appreciate as many teams as possible taking on this work so we're not having to touch hundreds of files by ourselves and in one go, the EUI team can potentially help you out - but we will need you to help QA that work and ensure your layouts look the same as before.

Thanks, and please feel free to reach out anytime with questions or help with migration!
@cee-chen cee-chen added deprecation_warnings EUI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Jul 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@petrklapka petrklapka mentioned this issue Jul 13, 2023
Closed
1 task
@kevinlog kevinlog self-assigned this Jul 14, 2023
@kevinlog kevinlog added the Team:Defend Workflows “EDR Workflows” sub-team of Security Solution label Jul 14, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@kevinlog kevinlog mentioned this issue Aug 25, 2023
Merged
kevinlog added a commit that referenced this issue Sep 13, 2023
@kevinlog @kibanamachine
[Security Solution] Remove deprecated EuiPage usages in EDR Workflows…
b35328f 
… pages (#162531)

## Summary

Updated our deprecated usages of `EuiPageTemplate` with the new
components.

Addresses this ticket: #161405

Below see the affected components after applying the new components

#### Administration/Endpoint List

<img width="1481" alt="image"
src="https://github.com/elastic/kibana/assets/56395104/3afdb8d2-56dc-4578-a1be-a7cc2879fa6b">

#### Policy error

<img width="1728" alt="image"
src="https://github.com/elastic/kibana/assets/56395104/cfa056ea-6998-41a0-b26a-d6cba7071f6d">

#### Policy details

<img width="1728" alt="image"
src="https://github.com/elastic/kibana/assets/56395104/9868ea46-d6bd-454d-b65e-0f0719b395b9">

#### Artifacts in policy

<img width="1728" alt="image"
src="https://github.com/elastic/kibana/assets/56395104/54f8f9b9-ba10-4d80-a91c-9b173137c3a7">

#### No artifacts in policy

<img width="1728" alt="image"
src="https://github.com/elastic/kibana/assets/56395104/62887c44-768d-401f-a2f0-414a8e8d837a">

#### No artifacts assigned in policy

<img width="1728" alt="image"
src="https://github.com/elastic/kibana/assets/56395104/b34f8789-ad14-4eba-8cb8-c1935ae36a08">

#### Empty artifact page

<img width="1726" alt="image"
src="https://github.com/elastic/kibana/assets/56395104/88565a6f-a0fc-4df4-91b6-9bc07baec787">

#### Artifact page

<img width="1728" alt="image"
src="https://github.com/elastic/kibana/assets/56395104/acee3ee3-d6e5-456c-a44e-69e8f8098cb4">

#### Empty Endpoint and Policy pages

<img width="1728" alt="image"
src="https://github.com/elastic/kibana/assets/56395104/5768cce5-aeb4-427b-a0c5-edfe3be43225">

<img width="1728" alt="image"
src="https://github.com/elastic/kibana/assets/56395104/a5f7f8cd-f843-48c2-89c1-db1d728cc553">

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinlog kevinlog

Labels
deprecation_warnings EUI OLM Sprint Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cee-chen @elasticmachine @kevinlog