[Lens] fix drag and drop overlay #162310
Merged
[Lens] fix drag and drop overlay #162310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
mbondyra
added
Team:Visualizations
|
Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations) |
mbondyra
added
the
release_note:skip
jughosta
approved these changes
Jul 20, 2023
dej611
approved these changes
Jul 20, 2023
MichaelMarcialis
approved these changes
Jul 24, 2023
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
## Summary Fixes elastic#160735 When implementing drag and drop for the first time, to move smoothly between the main drop target and extra drop targets (duplicate or swap), I created an extra overlay path that keeps the elements visible when moving around (so when user drags out of the main drop target in the direction of extra targets, we don't loose their visibility) Turns out it started causing the 🔝 bug in the recent versions. This solution is not needed anymore though. Right now we keep elements visible for a few seconds when user drags out no matter where the mouse cursor is, so that's enough to go from main target to extra targets. Here's the overlay path I removed (I added yellow transparent background so it's more visible) <img width="485" alt="Screenshot 2023-07-20 at 13 34 41" src="https://github.com/elastic/kibana/assets/4283304/69acb1ff-1ada-4987-b47e-da282f8b992d">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #160735
When implementing drag and drop for the first time, to move smoothly between the main drop target and extra drop targets (duplicate or swap), I created an extra overlay path that keeps the elements visible when moving around (so when user drags out of the main drop target in the direction of extra targets, we don't loose their visibility)
Turns out it started causing the 🔝 bug in the recent versions.
This solution is not needed anymore though. Right now we keep elements visible for a few seconds when user drags out no matter where the mouse cursor is, so that's enough to go from main target to extra targets.
Here's the overlay path I removed (I added yellow transparent background so it's more visible)
