Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Drag and drop sometimes doesn't work #160735

Closed
mbondyra opened this issue Jun 28, 2023 · 1 comment · Fixed by #162310
Closed

[Lens] Drag and drop sometimes doesn't work #160735

mbondyra opened this issue Jun 28, 2023 · 1 comment · Fixed by #162310
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@mbondyra
Copy link
Contributor

mbondyra commented Jun 28, 2023

Kibana version:
main, probably also 8.8 and 8.9

Sometimes, when dragging an element in Lens over the target, the target is not highlighted properly (it should take deeper yellow color on the example below) and doesn't execute a proper drop. Looks like something is overshadowing the drop target. Here's a video to demonstrate (sometimes it works properly)

draganddrop.mov
@mbondyra mbondyra added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jun 28, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@stratoula stratoula added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Jun 28, 2023
mbondyra added a commit that referenced this issue Jul 24, 2023
## Summary

Fixes #160735

When implementing drag and drop for the first time, to move smoothly
between the main drop target and extra drop targets (duplicate or swap),
I created an extra overlay path that keeps the elements visible when
moving around (so when user drags out of the main drop target in the
direction of extra targets, we don't loose their visibility)

Turns out it started causing the 🔝 bug in the recent versions. 

This solution is not needed anymore though. Right now we keep elements
visible for a few seconds when user drags out no matter where the mouse
cursor is, so that's enough to go from main target to extra targets.

Here's the overlay path I removed (I added yellow transparent background
so it's more visible)
<img width="485" alt="Screenshot 2023-07-20 at 13 34 41"
src="https://github.com/elastic/kibana/assets/4283304/69acb1ff-1ada-4987-b47e-da282f8b992d">
ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
## Summary

Fixes elastic#160735

When implementing drag and drop for the first time, to move smoothly
between the main drop target and extra drop targets (duplicate or swap),
I created an extra overlay path that keeps the elements visible when
moving around (so when user drags out of the main drop target in the
direction of extra targets, we don't loose their visibility)

Turns out it started causing the 🔝 bug in the recent versions. 

This solution is not needed anymore though. Right now we keep elements
visible for a few seconds when user drags out no matter where the mouse
cursor is, so that's enough to go from main target to extra targets.

Here's the overlay path I removed (I added yellow transparent background
so it's more visible)
<img width="485" alt="Screenshot 2023-07-20 at 13 34 41"
src="https://github.com/elastic/kibana/assets/4283304/69acb1ff-1ada-4987-b47e-da282f8b992d">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants