Upgrade EUI to 83.0.0 #160813

breehall · 2023-06-28T20:25:27Z

[email protected] ⏩ 83.0.0

⚠️ The biggest change in this PR by far is the EuiButtonEmpty Emotion conversion, which changes the DOM structure of the button slightly as well as several CSS classes around it.

EUI has attempted to convert any custom EuiButtonEmpty CSS overrides where possible, but would super appreciate it if CODEOWNERS checked their touched files. If anything other than a snapshot or test was touched, please double check the display of your button(s) and confirm everything still looks shipshape. Feel free to ping us for advice if not.

`83.0.0`

Bug fixes

Fixed EuiPaginationButton styling affected by EuiButtonEmpty's Emotion conversion (#6893)

Breaking changes

Removed isPlaceholder prop from EuiPaginationButton (#6893)

`82.2.1`

Updated supported Node engine versions to allow Node 16, 18 and >=20 (#6884)

`82.2.0`

Updated EUI's SVG icons library to use latest SVGO v3 optimization (#6843)
Added success color EuiNotificationBadge (#6864)
Added badgeColor prop to EuiFilterButton (#6864)
Updated EuiBadge to use CSS-in-JS for named colors instead of inline styles. Custom colors will still use inline styles. (#6864)

CSS-in-JS conversions

Converted EuiButtonGroup and EuiButtonGroupButton to Emotion (#6841)
Converted EuiButtonIcon to Emotion (#6844)
Converted EuiButtonEmpty to Emotion (#6863)
Converted EuiCollapsibleNav and EuiCollapsibleNavGroup to Emotion (#6865)
Removed Sass variables $euiCollapsibleNavGroupLightBackgroundColor, $euiCollapsibleNavGroupDarkBackgroundColor, and $euiCollapsibleNavGroupDarkHighContrastColor (#6865)

Merging in main

cee-chen · 2023-06-30T18:20:37Z

@elasticmachine merge upstream

- comment is likely no longer accurate (4 years old), and `EuiButtonIcon` supports a loading spinner just fine

- Remove references to removed modifier classes - Prefer checks for `disabled` prop over className checks

…prop

- these classNames no longer have any CSS attached due to the Emotion conversion - AFAICT, the overrides are primarily around text size and weight, so set those intead - use components where possible and Emotion CSS instead of inline style

- these classNames no longer have any CSS attached due to the Emotion conversion - AFAICT, the overrides are primarily around text size and weight, as well as an incidental hover, so set those instead

- remove `__content` selector - padding is now set on the parent button - use EUI theme var instead of static px width - clean up minimizePadding ternary - removing padding class on `EuiButtonIcon` which does not set any padding

- EuiButtonEmpty now has its padding set on the top-most button, and not on `euiButtonEmpty__content` + use new logical `-inline` property while here, which sets both horizontal sides at once

`.euiButtonEmpty__text` no longer uses `margin-left` to set a distance between any icon(s) and text, instead `.euiButtonEmpty__content` now sets a flex `gap` property

`.euiButtonContent__icon` is no longer in use (removed/deprecated) - asert on the data type instead

- there aren't any being used in Sass in any case

x-pack/plugins/lens/public/embeddable/embeddable_info_badges.tsx

...n-elastic-assistant/impl/data_anonymization_editor/context_editor/get_columns/index.test.tsx

ThomThomson

Presentation team snapshot changes LGTM! I also tested locally to ensure that the maps layers expand button properly shows the loading state, and I noticed something small - the drop shadow is removed while the button is loading. Are custom classes not properly applied to the icon button when it's loading?

Either way, this doesn't block the EUI upgrade

ThomThomson · 2023-07-04T16:40:39Z

...plugins/maps/public/connected_components/right_side_controls/layer_control/layer_control.tsx

  return (
    <EuiButtonIcon
      className="mapLayerControl__openLayerTOCButton"
      color="text"
+      isLoading={isLoading}


Nice simplification!

jpdjere

Reviewed and tested our Detection Rules Management codeowner changes; everything looks fine.

Not approving yet, but delegating to @spong so he can take a look at the changes @banderror tagged him in.

breehall · 2023-07-05T14:03:35Z

@elasticmachine merge upstream

breehall · 2023-07-05T16:18:34Z

@elasticmachine merge upstream

spong

Security Assistant changes LGTM, so that rounds out the Security Solution review. 👍 Thank you @banderror & @jpdjere for the ping here, and thank you @breehall for the upgrade! 🙌

…rom the default 8px

## Summary Skips flaky cypress tests to unblock PRs. These tests are determined to be flaky as they are failing in two unrelated PRs. #160912 #160813 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <[email protected]>

breehall · 2023-07-06T13:15:33Z

@elasticmachine merge upstream

breehall · 2023-07-06T15:50:33Z

@elasticmachine merge upstream

delanni

Licence checker changes 👌

breehall · 2023-07-06T17:43:54Z

@elasticmachine merge upstream

kibana-ci · 2023-07-06T18:59:41Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: d700b1b

Failed CI Steps

Test Failures

[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / Export rules exports only custom rules
[job] [logs] FTR Configs #30 / Machine Learning jobs update groups "before all" hook for "returns expected list of groups after update"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cases`	421.7KB	421.9KB	+167.0B
`cloudSecurityPosture`	229.1KB	228.9KB	-144.0B
`enterpriseSearch`	2.5MB	2.5MB	-156.0B
`infra`	1.9MB	1.9MB	+198.0B
`kubernetesSecurity`	38.8KB	38.8KB	-25.0B
`lens`	1.3MB	1.3MB	-34.0B
`maps`	2.7MB	2.7MB	-230.0B
`security`	567.0KB	567.0KB	+42.0B
`securitySolution`	11.0MB	11.0MB	-571.0B
`synthetics`	907.1KB	907.0KB	-69.0B
`unifiedSearch`	212.9KB	212.9KB	-30.0B
`uptime`	518.8KB	518.7KB	-118.0B
`visTypeVega`	1.7MB	1.7MB	+198.0B
total			-772.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kbnUiSharedDeps-css`	312.5KB	298.8KB	-13.7KB
`kbnUiSharedDeps-npmDll`	6.0MB	6.0MB	+5.5KB
`visualizationUiComponents`	38.3KB	38.2KB	-31.0B
total			-8.2KB

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	14	16	+2
`securitySolution`	410	414	+4
total			+6

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	15	17	+2
`securitySolution`	489	493	+4
total			+6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Upgrade EUI to version 82.2.1

8ed8661

breehall added release_note:skip Skip the PR/issue when compiling release notes EUI backport:skip This commit does not require backporting v8.9.0 labels Jun 28, 2023

breehall added 2 commits June 29, 2023 16:22

Merge branch 'main' of github.com:breehall/kibana into eui/82.2.1

aaae476

Merging in main

Update EUI to version 83.0.0

dcc6762

breehall changed the title ~~Upgrade EUI to 82.2.1~~ Upgrade EUI to 83.0.0 Jun 29, 2023

cee-chen force-pushed the eui/82.2.1 branch 4 times, most recently from 9d2134c to fe30181 Compare June 30, 2023 17:11

cee-chen force-pushed the eui/82.2.1 branch from a13ceab to d1480ef Compare June 30, 2023 19:16

breehall and others added 16 commits June 30, 2023 17:53

Upgrade EUI to version 82.2.1

905a22d

Update EUI to version 83.0.0

0fdb89c

[EuiButtonIcon] Remove direct class usage in favor of isLoading prop

f5c05ae

- comment is likely no longer accurate (4 years old), and `EuiButtonIcon` supports a loading spinner just fine

[EuiButtonIcon] Fix test assertions

14358ff

- Remove references to removed modifier classes - Prefer checks for `disabled` prop over className checks

[EuiButtonEmpty] Remove padding CSS unsets in favor of using flush …

2874375

…prop

[EuiButtonEmpty][cases] Replace direct .euiButtonEmpty className usage

c308824

- these classNames no longer have any CSS attached due to the Emotion conversion - AFAICT, the overrides are primarily around text size and weight, as well as an incidental hover, so set those instead

[EuiButtonEmpty] Clean up custom padding declaration

6ac82e6

- remove `__content` selector - padding is now set on the parent button - use EUI theme var instead of static px width - clean up minimizePadding ternary - removing padding class on `EuiButtonIcon` which does not set any padding

[EuiButtonEmpty] Update padding override selectors

0eef8ab

- EuiButtonEmpty now has its padding set on the top-most button, and not on `euiButtonEmpty__content` + use new logical `-inline` property while here, which sets both horizontal sides at once

[EuiButtonEmpty] Update text selectors

ef0ae19

`.euiButtonEmpty__text` no longer uses `margin-left` to set a distance between any icon(s) and text, instead `.euiButtonEmpty__content` now sets a flex `gap` property

[EuiButtonEmpty] Update removed modifier classes

b20ce86

[EuiButtonEmpty] Account for removed selector

3adb127

`.euiButtonContent__icon` is no longer in use (removed/deprecated) - asert on the data type instead

Update multiple button and collapsible nav snapshots

6cae2a9

[EuiButton] Misc snapshot updates

a8e8736

[EuiBadge] Update snapshots

742915d

[EuiCollapsibleNav] Remove Sass variable imports

7912370

- there aren't any being used in Sass in any case

drewdaemon reviewed Jul 3, 2023

View reviewed changes

x-pack/plugins/lens/public/embeddable/embeddable_info_badges.tsx Outdated Show resolved Hide resolved

banderror added the ci:all-cypress-suites label Jul 4, 2023

banderror reviewed Jul 4, 2023

View reviewed changes

...n-elastic-assistant/impl/data_anonymization_editor/context_editor/get_columns/index.test.tsx Show resolved Hide resolved

...n-elastic-assistant/impl/data_anonymization_editor/context_editor/get_columns/index.test.tsx Show resolved Hide resolved

JordanSh approved these changes Jul 4, 2023

View reviewed changes

mitodrummer approved these changes Jul 4, 2023

View reviewed changes

ThomThomson approved these changes Jul 4, 2023

View reviewed changes

jpdjere reviewed Jul 4, 2023

View reviewed changes

jpdjere requested a review from spong July 4, 2023 20:53

Merge branch 'main' into eui/82.2.1

7379c45

Merge branch 'main' into eui/82.2.1

38918b0

spong approved these changes Jul 5, 2023

View reviewed changes

kevinlog mentioned this pull request Jul 5, 2023

[Security Solution] Skip flaky cases cypress tests #161309

Merged

1 task

[Embeddable Info Badge] Change padding of EuiButtonIcon back to 4px f…

e096890

…rom the default 8px

Merge branch 'main' into eui/82.2.1

781766f

drewdaemon approved these changes Jul 6, 2023

View reviewed changes

Merge branch 'main' into eui/82.2.1

c3fffe3

delanni approved these changes Jul 6, 2023

View reviewed changes

Merge branch 'main' into eui/82.2.1

d700b1b

Ikuni17 merged commit 4cf630b into elastic:main Jul 6, 2023

kibanamachine added the v8.10.0 label Jul 6, 2023

mbondyra mentioned this pull request Jul 7, 2023

[Lens] Datatable visualization actions jump on hover #161441

Closed

Heenawter mentioned this pull request Jul 7, 2023

[Controls] Options List border radius misaligned #161464

Closed

cee-chen removed the v8.9.0 label Jul 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade EUI to 83.0.0 #160813

Upgrade EUI to 83.0.0 #160813

breehall commented Jun 28, 2023 •

edited by cee-chen

Loading

cee-chen commented Jun 30, 2023

ThomThomson left a comment

ThomThomson Jul 4, 2023

jpdjere left a comment

breehall commented Jul 5, 2023

breehall commented Jul 5, 2023

spong left a comment

breehall commented Jul 6, 2023

breehall commented Jul 6, 2023

delanni left a comment

breehall commented Jul 6, 2023

kibana-ci commented Jul 6, 2023

ESLint disabled line counts

Total ESLint disabled count

Upgrade EUI to 83.0.0 #160813

Upgrade EUI to 83.0.0 #160813

Conversation

breehall commented Jun 28, 2023 • edited by cee-chen Loading

83.0.0

82.2.1

82.2.0

cee-chen commented Jun 30, 2023

ThomThomson left a comment

Choose a reason for hiding this comment

ThomThomson Jul 4, 2023

Choose a reason for hiding this comment

jpdjere left a comment

Choose a reason for hiding this comment

breehall commented Jul 5, 2023

breehall commented Jul 5, 2023

spong left a comment

Choose a reason for hiding this comment

breehall commented Jul 6, 2023

breehall commented Jul 6, 2023

delanni left a comment

Choose a reason for hiding this comment

breehall commented Jul 6, 2023

kibana-ci commented Jul 6, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

Page load bundle

ESLint disabled line counts

Total ESLint disabled count

History

breehall commented Jun 28, 2023 •

edited by cee-chen

Loading

`83.0.0`

`82.2.1`

`82.2.0`