[Controls] Options List border radius misaligned #161464
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Input Control
Input controls visualization
impact:low
Addressing this issue will have a low level of impact on the quality/strength of our product.
loe:small
Small Level of Effort
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
Comments
ThomThomson
added
bug
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
4 tasks
|
I am currently on the navigation embeddable feature branch, which is still using EUI
So seems like something in EUI |
2 tasks
1 task
cee-chen
added a commit
that referenced
this issue
Jul 13, 2023
## Summary fixes #161441 fixes #161464 The recent `EuiButtonEmpty`/`EuiButtonIcon` Emotion conversions have highlighted a CSS order/specificity flaw in Kibana compared to EUI - EUI orders its Sass _after_ its Emotion styles (see https://elastic.github.io/eui/#/), and Kibana orders Sass _before_ Emotion styles. I'm not totally sure why Greg set up Kibana's style order the way he did in #134919, but at this point, EUI has enough of its baseline atom components converted to Emotion that remaining components in Sass are all generally molecules or higher level components that need to come after Emotion. ### QA - [x] Test as many pages in Kibana as possible to ensure no visual regressions 🤞 --------- Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Jul 13, 2023
## Summary fixes elastic#161441 fixes elastic#161464 The recent `EuiButtonEmpty`/`EuiButtonIcon` Emotion conversions have highlighted a CSS order/specificity flaw in Kibana compared to EUI - EUI orders its Sass _after_ its Emotion styles (see https://elastic.github.io/eui/#/), and Kibana orders Sass _before_ Emotion styles. I'm not totally sure why Greg set up Kibana's style order the way he did in elastic#134919, but at this point, EUI has enough of its baseline atom components converted to Emotion that remaining components in Sass are all generally molecules or higher level components that need to come after Emotion. ### QA - [x] Test as many pages in Kibana as possible to ensure no visual regressions 🤞 --------- Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit b9eae62)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Kibana version: 8.9.0 / main
Describe the bug: The design of the Options List button is off in main and in recent versions. The border between the label section and the input section should be straight, but is instead curved with a border radius. This may have been caused by an Eui update.
Screenshots (if relevant):
The text was updated successfully, but these errors were encountered: