[Tech Debt] Use consts for routes

[CoenWarmer]

Resolves #158146

Summary

This consolidates the route configuration of the Observability app.

Changes:

• Moves /config/paths.ts to /routes/paths.ts so they are closer together;
• Renames /routes/index.tsx to /routes/routes.tsx;
• reuses same consts for route path names everywhere (Locators, plugin.ts, etc)

[apmmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: ec563a8

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
observability	519	518	-1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
observability	1.0MB	1.0MB	-2.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
observability	70.4KB	71.4KB	+1.0KB

Unknown metric groups

API count

id	before	after	diff
observability	527	526	-1

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	14	16	+2
securitySolution	416	420	+4
total			+6

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	15	17	+2
securitySolution	497	501	+4
total			+6

History

• 💔 Build #138127 failed 65066e24dce3e82344531e0825d10bea79a59bdb
• 💔 Build #138113 failed fa96b3d57ec98b9fbbf79139e7d96f6126a8a28a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[maryam-saeidi]

Overall LGTM!

Added one question

[maryam-saeidi]

Question: What will happen in case of not having a ruleId? Will we show an error on the page?

I wonder why we didn't need to have this before.

[CoenWarmer]

Previously, in /config/paths.ts, we had:

   ...
   ruleDetails: (ruleId?: string | null) =>
      ruleId ? `${RULES_PAGE_LINK}/${encodeURI(ruleId)}` : RULES_PAGE_LINK,
   ...

This has now made more strict as well as consistent with the other details pages (Alert, SLO):

    ruleDetails: (ruleId: string) => `${OBSERVABILITY_BASE_PATH}${RULES_PATH}/${encodeURI(ruleId)}`,

[maryam-saeidi]

What will show in this case for rule details if there is no ruleId?