Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate route configuration #158146

Closed
CoenWarmer opened this issue May 20, 2023 · 1 comment · Fixed by #160521
Closed

Consolidate route configuration #158146

CoenWarmer opened this issue May 20, 2023 · 1 comment · Fixed by #160521
Assignees
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"

Comments

@CoenWarmer
Copy link
Contributor

CoenWarmer commented May 20, 2023

Part of #152783

📝 Summary

The route configuration for the Observability app is stored in x-pack/plugins/observability/public/routes/index.tsx. In x-pack/plugins/observability/public/config/paths.ts there are also paths configured separately which are used throughout the app.

Lets bring them closer together so it's not possible to accidentally change one without changing the other.

In addition, lets use the same route path constants everywhere in the app.

✅ Acceptance criteria

  • Route config should be stored in one place
  • Constants for routes should be reused everywhere in the app
@CoenWarmer CoenWarmer self-assigned this May 20, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label May 20, 2023
@CoenWarmer CoenWarmer added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" and removed needs-team Issues missing a team label labels May 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"
Projects
None yet
2 participants