Move csv_v2 and csv_searchsource to export type class #160041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rshen91
changed the title
rshen91
added
release_note:skip
9 tasks
## Summary This partially addresses elastic#158092 This PR refactors the generic function getExportType(). This PR is concerned only with the PDF export type and refactors it into a class instance. This class is then used in the request handler and the execute report functionality in Reporting. The execute_report.test.ts is removed in this PR and will be part of the clean up needed in a subsequent PR once CSV and PNG are also refactored to class instances instead of the getExportType() function.
## Summary This partially addresses elastic#158092 This PR refactors the generic function getExportType(). This PR is concerned only with the PDF export type and refactors it into a class instance. This class is then used in the request handler and the execute report functionality in Reporting. The execute_report.test.ts is removed in this PR and will be part of the clean up needed in a subsequent PR once CSV and PNG are also refactored to class instances instead of the getExportType() function.
rshen91
force-pushed
the
reporting/new-export-type-registry
branch
from
497f73c to
c43b014
Compare
## Summary This partially addresses elastic#158092 This PR refactors the generic function getExportType(). This PR is concerned only with the PDF export type and refactors it into a class instance. This class is then used in the request handler and the execute report functionality in Reporting. The execute_report.test.ts is removed in this PR and will be part of the clean up needed in a subsequent PR once CSV and PNG are also refactored to class instances instead of the getExportType() function.
rshen91
force-pushed
the
reporting/new-export-type-registry
branch
from
c43b014 to
7c87383
Compare
rshen91
force-pushed
the
reporting/new-export-type-registry
branch
from
7c87383 to
c7c7caf
Compare
tsullivan
reviewed
Jul 5, 2023
tsullivan
reviewed
Jul 5, 2023
x-pack/plugins/reporting/server/export_types/csv_searchsource/csv_searchsource.ts
Show resolved
Hide resolved
tsullivan
reviewed
Jul 5, 2023
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @rshen91 |
rshen91
added a commit
that referenced
this pull request
Jul 6, 2023
## Summary This is a part of #158092 This PR encompasses both csv_v2 and csv_searchsource as the CsvExportType and CsvSearchsourceExportType. Based on the reporting plugin readme, CsvSearchsourceExportType is currently used but CsvV2ExportType is refactored for when it can reach feature parity to csv searchsource. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Timothy Sullivan <[email protected]>
rshen91
added a commit
that referenced
this pull request
Jul 10, 2023
## Summary This is a part of #158092 This PR encompasses both csv_v2 and csv_searchsource as the CsvExportType and CsvSearchsourceExportType. Based on the reporting plugin readme, CsvSearchsourceExportType is currently used but CsvV2ExportType is refactored for when it can reach feature parity to csv searchsource. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Timothy Sullivan <[email protected]>
rshen91
added a commit
that referenced
this pull request
Jul 11, 2023
## Summary This is a part of #158092 This PR encompasses both csv_v2 and csv_searchsource as the CsvExportType and CsvSearchsourceExportType. Based on the reporting plugin readme, CsvSearchsourceExportType is currently used but CsvV2ExportType is refactored for when it can reach feature parity to csv searchsource. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Timothy Sullivan <[email protected]>
rshen91
added a commit
that referenced
this pull request
Jul 12, 2023
## Summary This is a part of #158092 This PR encompasses both csv_v2 and csv_searchsource as the CsvExportType and CsvSearchsourceExportType. Based on the reporting plugin readme, CsvSearchsourceExportType is currently used but CsvV2ExportType is refactored for when it can reach feature parity to csv searchsource. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Timothy Sullivan <[email protected]>
rshen91
added a commit
that referenced
this pull request
Jul 12, 2023
## Summary This is a part of #158092 This PR encompasses both csv_v2 and csv_searchsource as the CsvExportType and CsvSearchsourceExportType. Based on the reporting plugin readme, CsvSearchsourceExportType is currently used but CsvV2ExportType is refactored for when it can reach feature parity to csv searchsource. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Timothy Sullivan <[email protected]>
rshen91
added a commit
that referenced
this pull request
Jul 13, 2023
## Summary This is a part of #158092 This PR encompasses both csv_v2 and csv_searchsource as the CsvExportType and CsvSearchsourceExportType. Based on the reporting plugin readme, CsvSearchsourceExportType is currently used but CsvV2ExportType is refactored for when it can reach feature parity to csv searchsource. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Timothy Sullivan <[email protected]>
rshen91
added a commit
to rshen91/kibana
that referenced
this pull request
Jul 20, 2023
## Summary This is a part of elastic#158092 This PR encompasses both csv_v2 and csv_searchsource as the CsvExportType and CsvSearchsourceExportType. Based on the reporting plugin readme, CsvSearchsourceExportType is currently used but CsvV2ExportType is refactored for when it can reach feature parity to csv searchsource. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Timothy Sullivan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a part of #158092
This PR encompasses both csv_v2 and csv_searchsource as the CsvExportType and CsvSearchsourceExportType. Based on the reporting plugin readme, CsvSearchsourceExportType is currently used but CsvV2ExportType is refactored for when it can reach feature parity to csv searchsource.
Checklist