Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Csv Reporting into Class Implementation #158217

Closed
wants to merge 5 commits into from

Conversation

rshen91
Copy link
Contributor

@rshen91 rshen91 commented May 22, 2023

Summary

Partially addresses #158092

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@rshen91 rshen91 self-assigned this May 22, 2023
@rshen91 rshen91 added backport:skip This commit does not require backporting (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels May 22, 2023
@rshen91 rshen91 changed the title [Reporting] Move Csv Reporting into Class Implementation Move Csv Reporting into Class Implementation May 22, 2023
@kibana-ci
Copy link
Collaborator

kibana-ci commented May 23, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #3 / data modeling usage data with meta.isDeprecated jobTypes
  • [job] [logs] Jest Tests #3 / data modeling with empty data
  • [job] [logs] Jest Tests #3 / data modeling with metrics and execution times in the data
  • [job] [logs] Jest Tests #3 / data modeling with sparse data
  • [job] [logs] Jest Tests #3 / data modeling with usage data from the reporting/archived_reports es archive
  • [job] [logs] Jest Tests #3 / Reporting Plugin has a sync setup process
  • [job] [logs] Jest Tests #3 / Reporting Plugin has a sync startup process
  • [job] [logs] Jest Tests #3 / Reporting Plugin logs start issues
  • [job] [logs] Jest Tests #3 / Reporting Plugin registers an advanced setting for PDF logos
  • [job] [logs] Jest Integration Tests #2 / SO default search fields make sure management types have the correct mappings for default search fields
  • [job] [logs] Jest Integration Tests #2 / SO type registrations does not remove types from registrations without updating excludeOnUpgradeQuery

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rshen91

@rshen91
Copy link
Contributor Author

rshen91 commented Jun 21, 2023

Closing in favor of #160041

@rshen91 rshen91 closed this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants