Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visualizations] Unskips precalculater histogram FTs #159887

Merged
merged 2 commits into from
Jun 19, 2023
Merged

[Visualizations] Unskips precalculater histogram FTs #159887

merged 2 commits into from
Jun 19, 2023

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Jun 19, 2023 •
edited
Loading

Summary

Closes #159615

This started faling most possibly because ES upgraded the TDigest library used for percentiles elastic/elasticsearch#96086 and now we can have more accurate results.

Runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2397

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 411 415 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 494 498 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure failed-test A test failure on a tracked branch, potentially flaky-test v8.9.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Jun 19, 2023
@stratoula stratoula marked this pull request as ready for review June 19, 2023 08:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@stratoula stratoula requested a review from a team June 19, 2023 08:31
dej611
dej611 approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only 👍

@stratoula stratoula merged commit c131f41 into elastic:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting failed-test A test failure on a tracked branch, potentially flaky-test Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.9.0
Projects
None yet
Milestone
No milestone
4 participants
@stratoula @kibana-ci @elasticmachine @dej611