Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing ES Promotion: FTR Configs #47 / Visualize pre_calculated_histogram works in visualizations with median aggregation #159615

Closed
mistic opened this issue Jun 13, 2023 · 7 comments · Fixed by #159887
Assignees
Labels
failed-es-promotion Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@mistic
Copy link
Member

mistic commented Jun 13, 2023

Chrome X-Pack UI Functional Tests x-pack/test/functional/apps/visualize/precalculated_histogram.ts

Visualize pre_calculated_histogram works in visualizations with median aggregation

This failure is preventing the promotion of the current Elasticsearch snapshot.

For more information on the Elasticsearch snapshot process including how to reproduce using the unverified ES build please read the failed promotion annotation. Other important information can be found at:

Error: expected 3 to be above 3
    at Assertion.assert (expect.js:100:11)
    at Assertion.apply (expect.js:317:8)
    at Function.above (expect.js:531:15)
    at Context.<anonymous> (precalculated_histogram.ts:85:29)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Object.apply (wrap_function.js:73:16)
@mistic mistic added failed-es-promotion Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Jun 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@mistic
Copy link
Member Author

mistic commented Jun 13, 2023

Skipped.

main: eff5049

@davismcphee davismcphee added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Jun 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@davismcphee
Copy link
Contributor

@elastic/kibana-visualizations I don't see x-pack/test/functional/apps/visualize in CODEOWNERS, but this looks like it's related to visualizations, so I've relabelled to Team:Visualizations. Let me know if you disagree!

@stratoula
Copy link
Contributor

@davismcphee it is about this histogram fields and how they are rendered both in Discover and in aggbased visualizations so I would say it affects both of us. We are happy to take it though

@mistic this https://www.elastic.co/guide/en/kibana/master/development-es-snapshots.html redirects me to 404.

Can you give me more information about what ES promotion is about? Thank you a lot.

@mistic
Copy link
Member Author

mistic commented Jun 14, 2023

@stratoula you're right. Just updated to match the correct places to check for information

@stratoula
Copy link
Contributor

Thanx Tiago!

@stratoula stratoula added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Jun 15, 2023
@stratoula stratoula self-assigned this Jun 19, 2023
@stratoula stratoula removed the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Jun 19, 2023
stratoula added a commit that referenced this issue Jun 19, 2023
## Summary

Closes #159615

This started faling most possibly because ES upgraded the TDigest
library used for percentiles
elastic/elasticsearch#96086 and now we can have
more accurate results.


Runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-es-promotion Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants